oceanprotocol/provider

View on GitHub
ocean_provider/routes/consume.py

Summary

Maintainability
C
1 day
Test Coverage
A
93%

File consume.py has 380 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#
# Copyright 2023 Ocean Protocol Foundation
# SPDX-License-Identifier: Apache-2.0
#
import json
Severity: Minor
Found in ocean_provider/routes/consume.py - About 5 hrs to fix

    Function initialize has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

    def initialize():
        """Initialize a service access request.
        In order to consume a data service the user is required to send
        one datatoken to the provider.
    
    
    Severity: Minor
    Found in ocean_provider/routes/consume.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fileinfo has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    def fileinfo():
        """Retrieves Content-Type and Content-Length from the given URL or asset. Supports a payload of either url or did.
        This can be used by the publisher of an asset to check basic information
        about the URL(s). For now, this information consists of the Content-Type
        and Content-Length of the request, using primarily OPTIONS, with fallback
    Severity: Minor
    Found in ocean_provider/routes/consume.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return error_response(f"Provider {network_name}: " + message, 400, logger)
    Severity: Major
    Found in ocean_provider/routes/consume.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return error_response(
      Severity: Major
      Found in ocean_provider/routes/consume.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return response
        Severity: Major
        Found in ocean_provider/routes/consume.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return {"validOrder": _order_log.transactionHash.hex()}, 200
          Severity: Major
          Found in ocean_provider/routes/consume.py - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status