Sign upLogin

oceanprotocol/react

View on GitHub
Star
src/utils/dtUtils.ts

Summary

Maintainability
D
2 days
Test Coverage

Function getCheapestExchangePrice has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function getCheapestExchangePrice(
  ocean: Ocean,
  dataTokenAddress: string
): Promise<BestPrice> {
  try {
Severity: Minor
Found in src/utils/dtUtils.ts - About 1 hr to fix

    Function getFirstPoolPrice has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function getFirstPoolPrice(
  ocean: Ocean,
  dataTokenAddress: string,
  poolAddress?: string
): Promise<BestPrice> {
    Severity: Minor
    Found in src/utils/dtUtils.ts - About 1 hr to fix

      Function getCheapestPoolPrice has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function getCheapestPoolPrice(
  ocean: Ocean,
  dataTokenAddress: string
): Promise<BestPrice> {
  const tokenPools = await ocean.pool.searchPoolforDT(dataTokenAddress)
      Severity: Minor
      Found in src/utils/dtUtils.ts - About 1 hr to fix

        Function getFirstExchangePrice has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export async function getFirstExchangePrice(
  ocean: Ocean,
  dataTokenAddress: string
): Promise<BestPrice> {
  try {
        Severity: Minor
        Found in src/utils/dtUtils.ts - About 1 hr to fix

          Function getCheapestPoolPrice has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

          export async function getCheapestPoolPrice(
  ocean: Ocean,
  dataTokenAddress: string
): Promise<BestPrice> {
  const tokenPools = await ocean.pool.searchPoolforDT(dataTokenAddress)
          Severity: Minor
          Found in src/utils/dtUtils.ts - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getCheapestExchangePrice has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          export async function getCheapestExchangePrice(
  ocean: Ocean,
  dataTokenAddress: string
): Promise<BestPrice> {
  try {
          Severity: Minor
          Found in src/utils/dtUtils.ts - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            return {
    type: 'pool',
    pools: [cheapestPoolAddress],
    address: cheapestPoolAddress,
    value: Number(cheapestPoolPrice),
          Severity: Major
          Found in src/utils/dtUtils.ts and 1 other location - About 1 hr to fix
          src/utils/dtUtils.ts on lines 198..206

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            return {
    type: 'pool',
    pools: [firstPoolAddress],
    address: firstPoolAddress,
    value: Number(firstPoolPrice),
          Severity: Major
          Found in src/utils/dtUtils.ts and 1 other location - About 1 hr to fix
          src/utils/dtUtils.ts on lines 44..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              if (tokenExchanges === undefined || tokenExchanges.length === 0) {
      return {
        type: '',
        address: '',
        pools: [],
          Severity: Major
          Found in src/utils/dtUtils.ts and 3 other locations - About 1 hr to fix
          src/utils/dtUtils.ts on lines 10..19
          src/utils/dtUtils.ts on lines 120..129
          src/utils/dtUtils.ts on lines 164..173

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              if (tokenPools === undefined || tokenPools.length === 0) {
      return {
        type: '',
        address: '',
        pools: [],
          Severity: Major
          Found in src/utils/dtUtils.ts and 3 other locations - About 1 hr to fix
          src/utils/dtUtils.ts on lines 10..19
          src/utils/dtUtils.ts on lines 64..73
          src/utils/dtUtils.ts on lines 120..129

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              if (tokenExchanges === undefined || tokenExchanges.length === 0) {
      return {
        type: '',
        address: '',
        pools: [],
          Severity: Major
          Found in src/utils/dtUtils.ts and 3 other locations - About 1 hr to fix
          src/utils/dtUtils.ts on lines 10..19
          src/utils/dtUtils.ts on lines 64..73
          src/utils/dtUtils.ts on lines 164..173

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

            if (tokenPools === undefined || tokenPools.length === 0) {
    return {
      type: '',
      address: '',
      pools: [],
          Severity: Major
          Found in src/utils/dtUtils.ts and 3 other locations - About 1 hr to fix
          src/utils/dtUtils.ts on lines 64..73
          src/utils/dtUtils.ts on lines 120..129
          src/utils/dtUtils.ts on lines 164..173

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 58.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            try {
    const tokenExchanges = await ocean.fixedRateExchange.searchforDT(
      dataTokenAddress,
      '1'
    )
          Severity: Minor
          Found in src/utils/dtUtils.ts and 1 other location - About 55 mins to fix
          src/utils/dtUtils.ts on lines 115..152

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            try {
    const tokenExchanges = await ocean.fixedRateExchange.searchforDT(
      dataTokenAddress,
      '1'
    )
          Severity: Minor
          Found in src/utils/dtUtils.ts and 1 other location - About 55 mins to fix
          src/utils/dtUtils.ts on lines 59..108

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status