Sign upLogin

octree-gva/Zeitline

View on GitHub
Star

Showing 11 of 11 total issues

Function renderAxis has 123 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  renderAxis(pivots = null) {
    // Filter intervals and remove out of date range values
    const intervalsInRange = this.intervals
      .filter((int) => int[1] > this.dateRange[0] && int[0] < this.dateRange[1]);
Severity: Major
Found in packages/zeitline/src/timeline.js - About 4 hrs to fix

    File timeline.js has 337 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import * as d3 from './partial-d3';
import {throttle} from './utils';

// Default configuration
const defaults = {
    Severity: Minor
    Found in packages/zeitline/src/timeline.js - About 4 hrs to fix

      Function renderData has 79 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        renderData(data) {
    let dataTime = data
      .map((d) => [this.x(d.date), d.label, d.date])
      .sort((a, b) => a[0] - b[0]);
      Severity: Major
      Found in packages/zeitline/src/timeline.js - About 3 hrs to fix

        Function constructor has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          constructor(props) {
    super(props);

    this.state = {
      numberOfEvents: 1,
        Severity: Minor
        Found in packages/zeitline-react/demo/src/index.js - About 1 hr to fix

          Function checkAndNormalizeConf has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            checkAndNormalizeConf(conf) {
    if (!conf.dateRange || !conf.dateRange.reduce) {
      throw new TypeError('DateRange should be an array');
    }
          Severity: Minor
          Found in packages/zeitline/src/timeline.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function checkAndNormalizeConf has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            checkAndNormalizeConf(conf) {
    if (!conf.dateRange || !conf.dateRange.reduce) {
      throw new TypeError('DateRange should be an array');
    }
          Severity: Minor
          Found in packages/zeitline/src/timeline.js - About 1 hr to fix

            Function renderAxis has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              renderAxis(pivots = null) {
    // Filter intervals and remove out of date range values
    const intervalsInRange = this.intervals
      .filter((int) => int[1] > this.dateRange[0] && int[0] < this.dateRange[1]);
            Severity: Minor
            Found in packages/zeitline/src/timeline.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              beforeEach(() => {
    window = util.getWindowWithZeitline(conf);

    separations = window.document.querySelector('svg')
      .querySelectorAll('.pivot-group');
            Severity: Minor
            Found in packages/zeitline/test/timeline-intervals.spec.js and 1 other location - About 55 mins to fix
            packages/zeitline/test/timeline-clusters.spec.js on lines 55..60

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              beforeEach(() => {
    window = util.getWindowWithZeitline(conf);

    groups = window.document
      .querySelector('svg').querySelectorAll('.event-group');
            Severity: Minor
            Found in packages/zeitline/test/timeline-clusters.spec.js and 1 other location - About 55 mins to fix
            packages/zeitline/test/timeline-intervals.spec.js on lines 27..32

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function init has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              init() {
    this.svg = d3.select(this.selector);
    const {margin, animation} = this;
    this.width = +this.svg.attr('width') - margin.left - margin.right;
    this.height = +this.svg.attr('height') - margin.top - margin.bottom;
            Severity: Minor
            Found in packages/zeitline/src/timeline.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function renderData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              renderData(data) {
    let dataTime = data
      .map((d) => [this.x(d.date), d.label, d.date])
      .sort((a, b) => a[0] - b[0]);
            Severity: Minor
            Found in packages/zeitline/src/timeline.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language