oculus42/short-uuid

View on GitHub

Showing 7 of 9 total issues

Function exports has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = (() => {
  /**
   * @param {string} toAlphabet
   * @param {{ consistentLength: boolean }} [options]
   * @returns {{
Severity: Minor
Found in index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (() => {
  /**
   * @param {string} toAlphabet
   * @param {{ consistentLength: boolean }} [options]
   * @returns {{
Severity: Minor
Found in index.js - About 1 hr to fix

    Function makeConvertor has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const makeConvertor = (toAlphabet, options) => {
        // Default to Flickr 58
        const useAlphabet = toAlphabet || constants.flickrBase58;
    
        // Default to baseOptions
    Severity: Minor
    Found in index.js - About 1 hr to fix

      Unexpected parentheses around single function argument having a body with no curly braces.
      Open

            fromUUID: (uuid) => shortenUUID(uuid, fromHex, paddingParams),
      Severity: Minor
      Found in index.js by eslint

      Require parens in arrow function arguments (arrow-parens)

      Arrow functions can omit parentheses when they have exactly one parameter. In all other cases the parameter(s) must be wrapped in parentheses. This rule enforces the consistent use of parentheses in arrow functions.

      Rule Details

      This rule enforces parentheses around arrow function parameters regardless of arity. For example:

      /*eslint-env es6*/
      
      // Bad
      a => {}
      
      // Good
      (a) => {}

      Following this style will help you find arrow functions (=>) which may be mistakenly included in a condition when a comparison such as >= was the intent.

      /*eslint-env es6*/
      
      // Bad
      if (a => 2) {
      }
      
      // Good
      if (a >= 2) {
      }

      The rule can also be configured to discourage the use of parens when they are not required:

      /*eslint-env es6*/
      
      // Bad
      (a) => {}
      
      // Good
      a => {}

      Options

      This rule has a string option and an object one.

      String options are:

      • "always" (default) requires parens around arguments in all cases.
      • "as-needed" enforces no braces where they can be omitted.

      Object properties for variants of the "as-needed" option:

      • "requireForBlockBody": true modifies the as-needed rule in order to require parens if the function body is in an instructions block (surrounded by braces).

      always

      Examples of incorrect code for this rule with the default "always" option:

      /*eslint arrow-parens: ["error", "always"]*/
      /*eslint-env es6*/
      
      a => {};
      a => a;
      a => {'\n'};
      a.then(foo => {});
      a.then(foo => a);
      a(foo => { if (true) {} });

      Examples of correct code for this rule with the default "always" option:

      /*eslint arrow-parens: ["error", "always"]*/
      /*eslint-env es6*/
      
      () => {};
      (a) => {};
      (a) => a;
      (a) => {'\n'}
      a.then((foo) => {});
      a.then((foo) => { if (true) {} });

      If Statements

      One of the benefits of this option is that it prevents the incorrect use of arrow functions in conditionals:

      /*eslint-env es6*/
      
      var a = 1;
      var b = 2;
      // ...
      if (a => b) {
       console.log('bigger');
      } else {
       console.log('smaller');
      }
      // outputs 'bigger', not smaller as expected

      The contents of the if statement is an arrow function, not a comparison.

      If the arrow function is intentional, it should be wrapped in parens to remove ambiguity.

      /*eslint-env es6*/
      
      var a = 1;
      var b = 0;
      // ...
      if ((a) => b) {
       console.log('truthy value returned');
      } else {
       console.log('falsey value returned');
      }
      // outputs 'truthy value returned'

      The following is another example of this behavior:

      /*eslint-env es6*/
      
      var a = 1, b = 2, c = 3, d = 4;
      var f = a => b ? c: d;
      // f = ?

      f is an arrow function which takes a as an argument and returns the result of b ? c: d.

      This should be rewritten like so:

      /*eslint-env es6*/
      
      var a = 1, b = 2, c = 3, d = 4;
      var f = (a) => b ? c: d;

      as-needed

      Examples of incorrect code for this rule with the "as-needed" option:

      /*eslint arrow-parens: ["error", "as-needed"]*/
      /*eslint-env es6*/
      
      (a) => {};
      (a) => a;
      (a) => {'\n'};
      a.then((foo) => {});
      a.then((foo) => a);
      a((foo) => { if (true) {} });
      const f = /** @type {number} */(a) => a + a;
      const g = /* comment */ (a) => a + a;
      const h = (a) /* comment */ => a + a;

      Examples of correct code for this rule with the "as-needed" option:

      /*eslint arrow-parens: ["error", "as-needed"]*/
      /*eslint-env es6*/
      
      () => {};
      a => {};
      a => a;
      a => {'\n'};
      a.then(foo => {});
      a.then(foo => { if (true) {} });
      (a, b, c) => a;
      (a = 10) => a;
      ([a, b]) => a;
      ({a, b}) => a;
      const f = (/** @type {number} */a) => a + a;
      const g = (/* comment */ a) => a + a;
      const h = (a /* comment */) => a + a;

      requireForBlockBody

      Examples of incorrect code for the { "requireForBlockBody": true } option:

      /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
      /*eslint-env es6*/
      
      (a) => a;
      a => {};
      a => {'\n'};
      a.map((x) => x * x);
      a.map(x => {
        return x * x;
      });
      a.then(foo => {});

      Examples of correct code for the { "requireForBlockBody": true } option:

      /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
      /*eslint-env es6*/
      
      (a) => {};
      (a) => {'\n'};
      a => ({});
      () => {};
      a => a;
      a.then((foo) => {});
      a.then((foo) => { if (true) {} });
      a((foo) => { if (true) {} });
      (a, b, c) => a;
      (a = 10) => a;
      ([a, b]) => a;
      ({a, b}) => a;

      Further Reading

      Unexpected parentheses around single function argument having a body with no curly braces.
      Open

      const getShortIdLength = (alphabetLength) => (
      Severity: Minor
      Found in index.js by eslint

      Require parens in arrow function arguments (arrow-parens)

      Arrow functions can omit parentheses when they have exactly one parameter. In all other cases the parameter(s) must be wrapped in parentheses. This rule enforces the consistent use of parentheses in arrow functions.

      Rule Details

      This rule enforces parentheses around arrow function parameters regardless of arity. For example:

      /*eslint-env es6*/
      
      // Bad
      a => {}
      
      // Good
      (a) => {}

      Following this style will help you find arrow functions (=>) which may be mistakenly included in a condition when a comparison such as >= was the intent.

      /*eslint-env es6*/
      
      // Bad
      if (a => 2) {
      }
      
      // Good
      if (a >= 2) {
      }

      The rule can also be configured to discourage the use of parens when they are not required:

      /*eslint-env es6*/
      
      // Bad
      (a) => {}
      
      // Good
      a => {}

      Options

      This rule has a string option and an object one.

      String options are:

      • "always" (default) requires parens around arguments in all cases.
      • "as-needed" enforces no braces where they can be omitted.

      Object properties for variants of the "as-needed" option:

      • "requireForBlockBody": true modifies the as-needed rule in order to require parens if the function body is in an instructions block (surrounded by braces).

      always

      Examples of incorrect code for this rule with the default "always" option:

      /*eslint arrow-parens: ["error", "always"]*/
      /*eslint-env es6*/
      
      a => {};
      a => a;
      a => {'\n'};
      a.then(foo => {});
      a.then(foo => a);
      a(foo => { if (true) {} });

      Examples of correct code for this rule with the default "always" option:

      /*eslint arrow-parens: ["error", "always"]*/
      /*eslint-env es6*/
      
      () => {};
      (a) => {};
      (a) => a;
      (a) => {'\n'}
      a.then((foo) => {});
      a.then((foo) => { if (true) {} });

      If Statements

      One of the benefits of this option is that it prevents the incorrect use of arrow functions in conditionals:

      /*eslint-env es6*/
      
      var a = 1;
      var b = 2;
      // ...
      if (a => b) {
       console.log('bigger');
      } else {
       console.log('smaller');
      }
      // outputs 'bigger', not smaller as expected

      The contents of the if statement is an arrow function, not a comparison.

      If the arrow function is intentional, it should be wrapped in parens to remove ambiguity.

      /*eslint-env es6*/
      
      var a = 1;
      var b = 0;
      // ...
      if ((a) => b) {
       console.log('truthy value returned');
      } else {
       console.log('falsey value returned');
      }
      // outputs 'truthy value returned'

      The following is another example of this behavior:

      /*eslint-env es6*/
      
      var a = 1, b = 2, c = 3, d = 4;
      var f = a => b ? c: d;
      // f = ?

      f is an arrow function which takes a as an argument and returns the result of b ? c: d.

      This should be rewritten like so:

      /*eslint-env es6*/
      
      var a = 1, b = 2, c = 3, d = 4;
      var f = (a) => b ? c: d;

      as-needed

      Examples of incorrect code for this rule with the "as-needed" option:

      /*eslint arrow-parens: ["error", "as-needed"]*/
      /*eslint-env es6*/
      
      (a) => {};
      (a) => a;
      (a) => {'\n'};
      a.then((foo) => {});
      a.then((foo) => a);
      a((foo) => { if (true) {} });
      const f = /** @type {number} */(a) => a + a;
      const g = /* comment */ (a) => a + a;
      const h = (a) /* comment */ => a + a;

      Examples of correct code for this rule with the "as-needed" option:

      /*eslint arrow-parens: ["error", "as-needed"]*/
      /*eslint-env es6*/
      
      () => {};
      a => {};
      a => a;
      a => {'\n'};
      a.then(foo => {});
      a.then(foo => { if (true) {} });
      (a, b, c) => a;
      (a = 10) => a;
      ([a, b]) => a;
      ({a, b}) => a;
      const f = (/** @type {number} */a) => a + a;
      const g = (/* comment */ a) => a + a;
      const h = (a /* comment */) => a + a;

      requireForBlockBody

      Examples of incorrect code for the { "requireForBlockBody": true } option:

      /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
      /*eslint-env es6*/
      
      (a) => a;
      a => {};
      a => {'\n'};
      a.map((x) => x * x);
      a.map(x => {
        return x * x;
      });
      a.then(foo => {});

      Examples of correct code for the { "requireForBlockBody": true } option:

      /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
      /*eslint-env es6*/
      
      (a) => {};
      (a) => {'\n'};
      a => ({});
      () => {};
      a => a;
      a.then((foo) => {});
      a.then((foo) => { if (true) {} });
      a((foo) => { if (true) {} });
      (a, b, c) => a;
      (a = 10) => a;
      ([a, b]) => a;
      ({a, b}) => a;

      Further Reading

      Unexpected parentheses around single function argument having a body with no curly braces.
      Open

            toUUID: (shortUuid) => enlargeUUID(shortUuid, toHex),
      Severity: Minor
      Found in index.js by eslint

      Require parens in arrow function arguments (arrow-parens)

      Arrow functions can omit parentheses when they have exactly one parameter. In all other cases the parameter(s) must be wrapped in parentheses. This rule enforces the consistent use of parentheses in arrow functions.

      Rule Details

      This rule enforces parentheses around arrow function parameters regardless of arity. For example:

      /*eslint-env es6*/
      
      // Bad
      a => {}
      
      // Good
      (a) => {}

      Following this style will help you find arrow functions (=>) which may be mistakenly included in a condition when a comparison such as >= was the intent.

      /*eslint-env es6*/
      
      // Bad
      if (a => 2) {
      }
      
      // Good
      if (a >= 2) {
      }

      The rule can also be configured to discourage the use of parens when they are not required:

      /*eslint-env es6*/
      
      // Bad
      (a) => {}
      
      // Good
      a => {}

      Options

      This rule has a string option and an object one.

      String options are:

      • "always" (default) requires parens around arguments in all cases.
      • "as-needed" enforces no braces where they can be omitted.

      Object properties for variants of the "as-needed" option:

      • "requireForBlockBody": true modifies the as-needed rule in order to require parens if the function body is in an instructions block (surrounded by braces).

      always

      Examples of incorrect code for this rule with the default "always" option:

      /*eslint arrow-parens: ["error", "always"]*/
      /*eslint-env es6*/
      
      a => {};
      a => a;
      a => {'\n'};
      a.then(foo => {});
      a.then(foo => a);
      a(foo => { if (true) {} });

      Examples of correct code for this rule with the default "always" option:

      /*eslint arrow-parens: ["error", "always"]*/
      /*eslint-env es6*/
      
      () => {};
      (a) => {};
      (a) => a;
      (a) => {'\n'}
      a.then((foo) => {});
      a.then((foo) => { if (true) {} });

      If Statements

      One of the benefits of this option is that it prevents the incorrect use of arrow functions in conditionals:

      /*eslint-env es6*/
      
      var a = 1;
      var b = 2;
      // ...
      if (a => b) {
       console.log('bigger');
      } else {
       console.log('smaller');
      }
      // outputs 'bigger', not smaller as expected

      The contents of the if statement is an arrow function, not a comparison.

      If the arrow function is intentional, it should be wrapped in parens to remove ambiguity.

      /*eslint-env es6*/
      
      var a = 1;
      var b = 0;
      // ...
      if ((a) => b) {
       console.log('truthy value returned');
      } else {
       console.log('falsey value returned');
      }
      // outputs 'truthy value returned'

      The following is another example of this behavior:

      /*eslint-env es6*/
      
      var a = 1, b = 2, c = 3, d = 4;
      var f = a => b ? c: d;
      // f = ?

      f is an arrow function which takes a as an argument and returns the result of b ? c: d.

      This should be rewritten like so:

      /*eslint-env es6*/
      
      var a = 1, b = 2, c = 3, d = 4;
      var f = (a) => b ? c: d;

      as-needed

      Examples of incorrect code for this rule with the "as-needed" option:

      /*eslint arrow-parens: ["error", "as-needed"]*/
      /*eslint-env es6*/
      
      (a) => {};
      (a) => a;
      (a) => {'\n'};
      a.then((foo) => {});
      a.then((foo) => a);
      a((foo) => { if (true) {} });
      const f = /** @type {number} */(a) => a + a;
      const g = /* comment */ (a) => a + a;
      const h = (a) /* comment */ => a + a;

      Examples of correct code for this rule with the "as-needed" option:

      /*eslint arrow-parens: ["error", "as-needed"]*/
      /*eslint-env es6*/
      
      () => {};
      a => {};
      a => a;
      a => {'\n'};
      a.then(foo => {});
      a.then(foo => { if (true) {} });
      (a, b, c) => a;
      (a = 10) => a;
      ([a, b]) => a;
      ({a, b}) => a;
      const f = (/** @type {number} */a) => a + a;
      const g = (/* comment */ a) => a + a;
      const h = (a /* comment */) => a + a;

      requireForBlockBody

      Examples of incorrect code for the { "requireForBlockBody": true } option:

      /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
      /*eslint-env es6*/
      
      (a) => a;
      a => {};
      a => {'\n'};
      a.map((x) => x * x);
      a.map(x => {
        return x * x;
      });
      a.then(foo => {});

      Examples of correct code for the { "requireForBlockBody": true } option:

      /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
      /*eslint-env es6*/
      
      (a) => {};
      (a) => {'\n'};
      a => ({});
      () => {};
      a => a;
      a.then((foo) => {});
      a.then((foo) => { if (true) {} });
      a((foo) => { if (true) {} });
      (a, b, c) => a;
      (a = 10) => a;
      ([a, b]) => a;
      ({a, b}) => a;

      Further Reading

      Unexpected parentheses around single function argument having a body with no curly braces.
      Open

            const onlyAlphabet = shortId.split('').every((letter) => useAlphabet.includes(letter));
      Severity: Minor
      Found in index.js by eslint

      Require parens in arrow function arguments (arrow-parens)

      Arrow functions can omit parentheses when they have exactly one parameter. In all other cases the parameter(s) must be wrapped in parentheses. This rule enforces the consistent use of parentheses in arrow functions.

      Rule Details

      This rule enforces parentheses around arrow function parameters regardless of arity. For example:

      /*eslint-env es6*/
      
      // Bad
      a => {}
      
      // Good
      (a) => {}

      Following this style will help you find arrow functions (=>) which may be mistakenly included in a condition when a comparison such as >= was the intent.

      /*eslint-env es6*/
      
      // Bad
      if (a => 2) {
      }
      
      // Good
      if (a >= 2) {
      }

      The rule can also be configured to discourage the use of parens when they are not required:

      /*eslint-env es6*/
      
      // Bad
      (a) => {}
      
      // Good
      a => {}

      Options

      This rule has a string option and an object one.

      String options are:

      • "always" (default) requires parens around arguments in all cases.
      • "as-needed" enforces no braces where they can be omitted.

      Object properties for variants of the "as-needed" option:

      • "requireForBlockBody": true modifies the as-needed rule in order to require parens if the function body is in an instructions block (surrounded by braces).

      always

      Examples of incorrect code for this rule with the default "always" option:

      /*eslint arrow-parens: ["error", "always"]*/
      /*eslint-env es6*/
      
      a => {};
      a => a;
      a => {'\n'};
      a.then(foo => {});
      a.then(foo => a);
      a(foo => { if (true) {} });

      Examples of correct code for this rule with the default "always" option:

      /*eslint arrow-parens: ["error", "always"]*/
      /*eslint-env es6*/
      
      () => {};
      (a) => {};
      (a) => a;
      (a) => {'\n'}
      a.then((foo) => {});
      a.then((foo) => { if (true) {} });

      If Statements

      One of the benefits of this option is that it prevents the incorrect use of arrow functions in conditionals:

      /*eslint-env es6*/
      
      var a = 1;
      var b = 2;
      // ...
      if (a => b) {
       console.log('bigger');
      } else {
       console.log('smaller');
      }
      // outputs 'bigger', not smaller as expected

      The contents of the if statement is an arrow function, not a comparison.

      If the arrow function is intentional, it should be wrapped in parens to remove ambiguity.

      /*eslint-env es6*/
      
      var a = 1;
      var b = 0;
      // ...
      if ((a) => b) {
       console.log('truthy value returned');
      } else {
       console.log('falsey value returned');
      }
      // outputs 'truthy value returned'

      The following is another example of this behavior:

      /*eslint-env es6*/
      
      var a = 1, b = 2, c = 3, d = 4;
      var f = a => b ? c: d;
      // f = ?

      f is an arrow function which takes a as an argument and returns the result of b ? c: d.

      This should be rewritten like so:

      /*eslint-env es6*/
      
      var a = 1, b = 2, c = 3, d = 4;
      var f = (a) => b ? c: d;

      as-needed

      Examples of incorrect code for this rule with the "as-needed" option:

      /*eslint arrow-parens: ["error", "as-needed"]*/
      /*eslint-env es6*/
      
      (a) => {};
      (a) => a;
      (a) => {'\n'};
      a.then((foo) => {});
      a.then((foo) => a);
      a((foo) => { if (true) {} });
      const f = /** @type {number} */(a) => a + a;
      const g = /* comment */ (a) => a + a;
      const h = (a) /* comment */ => a + a;

      Examples of correct code for this rule with the "as-needed" option:

      /*eslint arrow-parens: ["error", "as-needed"]*/
      /*eslint-env es6*/
      
      () => {};
      a => {};
      a => a;
      a => {'\n'};
      a.then(foo => {});
      a.then(foo => { if (true) {} });
      (a, b, c) => a;
      (a = 10) => a;
      ([a, b]) => a;
      ({a, b}) => a;
      const f = (/** @type {number} */a) => a + a;
      const g = (/* comment */ a) => a + a;
      const h = (a /* comment */) => a + a;

      requireForBlockBody

      Examples of incorrect code for the { "requireForBlockBody": true } option:

      /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
      /*eslint-env es6*/
      
      (a) => a;
      a => {};
      a => {'\n'};
      a.map((x) => x * x);
      a.map(x => {
        return x * x;
      });
      a.then(foo => {});

      Examples of correct code for the { "requireForBlockBody": true } option:

      /*eslint arrow-parens: [2, "as-needed", { "requireForBlockBody": true }]*/
      /*eslint-env es6*/
      
      (a) => {};
      (a) => {'\n'};
      a => ({});
      () => {};
      a => a;
      a.then((foo) => {});
      a.then((foo) => { if (true) {} });
      a((foo) => { if (true) {} });
      (a, b, c) => a;
      (a = 10) => a;
      ([a, b]) => a;
      ({a, b}) => a;

      Further Reading

      Severity
      Category
      Status
      Source
      Language