Sign upLogin

odin-detector/odin-data

View on GitHub
Star

Showing 110 of 110 total issues

Function send_to_clients has a Cognitive Complexity of 48 (exceeds 5 allowed). Consider refactoring.
Open

    def send_to_clients(self, request_command, parameters, client_index=-1):
        """
        Intercept the base class send_to_clients method.
        Keep a record of any decoder specific configuration items and then if a single decoder config
        item is later changed send the full decoder configuration to the Frame Receiver application.
Severity: Minor
Found in python/src/odin_data/control/frame_receiver_adapter.py - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File meta_writer.py has 438 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"""Implementation of odin_data Meta Writer

This module is passed meta data messages for a single acquisition which it writes to disk.
Will need to be subclassed by detector specific implementation.
Severity: Minor
Found in python/src/odin_data/meta_writer/meta_writer.py - About 6 hrs to fix

    File odin_data_adapter.py has 417 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    """
Created on 6th September 2017

:author: Alan Greer
"""
    Severity: Minor
    Found in python/src/odin_data/control/odin_data_adapter.py - About 6 hrs to fix

      Function get has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

          def get(self, path, request):

        """
        Implementation of the HTTP GET verb for OdinDataAdapter
      Severity: Minor
      Found in python/src/odin_data/control/odin_data_adapter.py - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File hdf5dataset.py has 390 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import logging
from time import time
from typing import Optional

import h5py as h5
      Severity: Minor
      Found in python/src/odin_data/meta_writer/hdf5dataset.py - About 5 hrs to fix

        File _version.py has 377 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # This file helps to compute a version number in source trees obtained from
# git-archive tarball (such as those provided by githubs download-from-tag
# feature). Distribution tarballs (built by setup.py sdist) and build
# directories (produced by setup.py build) will contain a much shorter file
# that just contains the computed version number.
        Severity: Minor
        Found in python/src/odin_data/_version.py - About 5 hrs to fix

          Function send_to_clients has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
          Open

              def send_to_clients(self, request_command, parameters, client_index=-1):
        status_code = 200
        response = {}

        # Check if the parameters object is a list
          Severity: Minor
          Found in python/src/odin_data/control/odin_data_adapter.py - About 4 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method buildGUI has 111 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private Panel buildGUI()
    {
        panel = new Panel();
        panel.setLayout(new GridBagLayout());
          Severity: Major
          Found in tools/imagej/src/Live_View.java - About 4 hrs to fix

            File Live_View.java has 341 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import java.awt.*;
import java.awt.event.*;

import java.text.SimpleDateFormat;
import java.util.Date;
            Severity: Minor
            Found in tools/imagej/src/Live_View.java - About 4 hrs to fix

              Function __init__ has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
              Open

                  def __init__(self, shared_mem_name, shared_mem_size=0, buffer_size=0,
                 remove_when_deleted=False, boost_mmap_mode=False):

        self.remove_when_deleted = remove_when_deleted
        self.shared_mem = None
              Severity: Minor
              Found in python/src/odin_data/shared_buffer_manager.py - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function put has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
              Open

                  def put(self, path, request):  # pylint: disable=W0613

        """
        Implementation of the HTTP PUT verb for OdinDataAdapter
              Severity: Minor
              Found in python/src/odin_data/control/frame_processor_adapter.py - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              MetaWriter has 31 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class MetaWriter(object):
    """This class handles meta data messages and writes parameters to disk"""

    FILE_SUFFIX = "_meta.h5"
    CONFIGURE_PARAMETERS = [
              Severity: Minor
              Found in python/src/odin_data/meta_writer/meta_writer.py - About 3 hrs to fix

                File live_view_adapter.py has 325 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                """ODIN data live view adapter.

This module implements an odin-control adapter capable of rendering odin-data live
view images to users.
                Severity: Minor
                Found in python/src/odin_data/control/live_view_adapter.py - About 3 hrs to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                          try:
            index = int(uri_items[-1])
            if index >= 0:
                # This is a valid index so remove the value from the URI
                request_command = remove_suffix(request_command, "/" + uri_items[-1])
                  Severity: Major
                  Found in python/src/odin_data/control/odin_data_adapter.py and 1 other location - About 3 hrs to fix
                  python/src/odin_data/control/odin_data_adapter.py on lines 349..357

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 70.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                              try:
                index = int(uri_items[-1])
                if index >= 0:
                    # This is a valid index so remove the value from the URI
                    request_command = remove_suffix(request_command, "/" + uri_items[-1])
                  Severity: Major
                  Found in python/src/odin_data/control/odin_data_adapter.py and 1 other location - About 3 hrs to fix
                  python/src/odin_data/control/odin_data_adapter.py on lines 278..286

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 70.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  File meta_listener.py has 318 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  """Implementation of odin_data Meta Listener

This module listens on one or more ZeroMQ sockets for meta messages which it then passes
on to a MetaWriter to write. Also handles odin Ipc control messages.
                  Severity: Minor
                  Found in python/src/odin_data/meta_writer/meta_listener.py - About 3 hrs to fix

                    Function put has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def put(self, path, request):  # pylint: disable=W0613

        """
        Implementation of the HTTP PUT verb for OdinDataAdapter
                    Severity: Minor
                    Found in python/src/odin_data/control/odin_data_adapter.py - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function check_fr_status has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def check_fr_status(self):
        valid_check = True
        reason = ''
        # We should have a valid connection to the FR adapter
        if self._fr_adapter is not None:
                    Severity: Minor
                    Found in python/src/odin_data/control/frame_processor_adapter.py - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    for index in range(len(self._decoder_config)):
                    if self._decoder_config[index] is None:
                        self._decoder_config[index] = decoder_config
                    else:
                        for item in decoder_config:
                    Severity: Major
                    Found in python/src/odin_data/control/frame_receiver_adapter.py and 1 other location - About 3 hrs to fix
                    python/src/odin_data/control/frame_receiver_adapter.py on lines 66..78

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                                if client_index == -1:
                for index in range(len(self._decoder_config)):
                    if self._decoder_config[index] is None:
                        self._decoder_config[index] = decoder_config
                    else:
                    Severity: Major
                    Found in python/src/odin_data/control/frame_receiver_adapter.py and 1 other location - About 3 hrs to fix
                    python/src/odin_data/control/frame_receiver_adapter.py on lines 67..72

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 63.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language