oemof/oemof-solph

View on GitHub
examples/cellular/cellular.py

Summary

Maintainability
F
3 days
Test Coverage

Function main has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

def main():
    ###########################################################################
    # define the cells of the cellular energy system
    ###########################################################################
    # define necessary parameters
Severity: Major
Found in examples/cellular/cellular.py - About 3 hrs to fix

    File cellular.py has 281 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    """
    General description
    -------------------
    
    Cellular energy systems are proposed by the VDE-ETG. They are, as the name
    Severity: Minor
    Found in examples/cellular/cellular.py - About 2 hrs to fix

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          connector_el_ec_1_1 = cmp.Link(
              label="connector_el_ec_1_1",
              inputs={
                  bus_el_ec_1: flows.Flow(),
                  bus_el_ec_1_1: flows.Flow(),
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 3 hrs to fix
      examples/cellular/cellular.py on lines 193..205
      examples/cellular/cellular.py on lines 209..221
      examples/cellular/cellular.py on lines 241..253
      examples/cellular/cellular.py on lines 257..269
      examples/cellular/cellular.py on lines 273..285

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          connector_el_ec_2_1 = cmp.Link(
              label="connector_el_ec_2_1",
              inputs={
                  bus_el_ec_2: flows.Flow(),
                  bus_el_ec_2_1: flows.Flow(),
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 3 hrs to fix
      examples/cellular/cellular.py on lines 193..205
      examples/cellular/cellular.py on lines 209..221
      examples/cellular/cellular.py on lines 225..237
      examples/cellular/cellular.py on lines 241..253
      examples/cellular/cellular.py on lines 273..285

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          connector_el_ec_2_2 = cmp.Link(
              label="connector_el_ec_2_2",
              inputs={
                  bus_el_ec_2: flows.Flow(),
                  bus_el_ec_2_2: flows.Flow(),
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 3 hrs to fix
      examples/cellular/cellular.py on lines 193..205
      examples/cellular/cellular.py on lines 209..221
      examples/cellular/cellular.py on lines 225..237
      examples/cellular/cellular.py on lines 241..253
      examples/cellular/cellular.py on lines 257..269

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          connector_el_ec_2 = cmp.Link(
              label="connector_el_ec_2",
              inputs={
                  bus_el_es: flows.Flow(),
                  bus_el_ec_2: flows.Flow(),
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 3 hrs to fix
      examples/cellular/cellular.py on lines 193..205
      examples/cellular/cellular.py on lines 225..237
      examples/cellular/cellular.py on lines 241..253
      examples/cellular/cellular.py on lines 257..269
      examples/cellular/cellular.py on lines 273..285

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          connector_el_ec_1 = cmp.Link(
              label="connector_el_ec_1",
              inputs={
                  bus_el_es: flows.Flow(),
                  bus_el_ec_1: flows.Flow(),
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 3 hrs to fix
      examples/cellular/cellular.py on lines 209..221
      examples/cellular/cellular.py on lines 225..237
      examples/cellular/cellular.py on lines 241..253
      examples/cellular/cellular.py on lines 257..269
      examples/cellular/cellular.py on lines 273..285

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          connector_el_ec_1_2 = cmp.Link(
              label="connector_el_ec_1_2",
              inputs={
                  bus_el_ec_1: flows.Flow(),
                  bus_el_ec_1_2: flows.Flow(),
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 3 hrs to fix
      examples/cellular/cellular.py on lines 193..205
      examples/cellular/cellular.py on lines 209..221
      examples/cellular/cellular.py on lines 225..237
      examples/cellular/cellular.py on lines 257..269
      examples/cellular/cellular.py on lines 273..285

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          source_el_ec_2 = cmp.Source(
              label="source_el_ec_2",
              outputs={
                  bus_el_ec_2: flows.Flow(
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 40 mins to fix
      examples/cellular/cellular.py on lines 137..140
      examples/cellular/cellular.py on lines 153..156
      examples/cellular/cellular.py on lines 161..164
      examples/cellular/cellular.py on lines 169..172
      examples/cellular/cellular.py on lines 177..180

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          source_el_ec_1_2 = cmp.Source(
              label="source_el_ec_1_2",
              outputs={
                  bus_el_ec_1_2: flows.Flow(
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 40 mins to fix
      examples/cellular/cellular.py on lines 137..140
      examples/cellular/cellular.py on lines 145..148
      examples/cellular/cellular.py on lines 153..156
      examples/cellular/cellular.py on lines 169..172
      examples/cellular/cellular.py on lines 177..180

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          source_el_ec_1 = cmp.Source(
              label="source_el_ec_1",
              outputs={
                  bus_el_ec_1: flows.Flow(
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 40 mins to fix
      examples/cellular/cellular.py on lines 145..148
      examples/cellular/cellular.py on lines 153..156
      examples/cellular/cellular.py on lines 161..164
      examples/cellular/cellular.py on lines 169..172
      examples/cellular/cellular.py on lines 177..180

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          source_el_ec_2_1 = cmp.Source(
              label="source_el_ec_2_1",
              outputs={
                  bus_el_ec_2_1: flows.Flow(
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 40 mins to fix
      examples/cellular/cellular.py on lines 137..140
      examples/cellular/cellular.py on lines 145..148
      examples/cellular/cellular.py on lines 153..156
      examples/cellular/cellular.py on lines 161..164
      examples/cellular/cellular.py on lines 177..180

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          source_el_ec_2_2 = cmp.Source(
              label="source_el_ec_2_2",
              outputs={
                  bus_el_ec_2_2: flows.Flow(
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 40 mins to fix
      examples/cellular/cellular.py on lines 137..140
      examples/cellular/cellular.py on lines 145..148
      examples/cellular/cellular.py on lines 153..156
      examples/cellular/cellular.py on lines 161..164
      examples/cellular/cellular.py on lines 169..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

          source_el_ec_1_1 = cmp.Source(
              label="source_el_ec_1_1",
              outputs={
                  bus_el_ec_1_1: flows.Flow(
      Severity: Major
      Found in examples/cellular/cellular.py and 5 other locations - About 40 mins to fix
      examples/cellular/cellular.py on lines 137..140
      examples/cellular/cellular.py on lines 145..148
      examples/cellular/cellular.py on lines 161..164
      examples/cellular/cellular.py on lines 169..172
      examples/cellular/cellular.py on lines 177..180

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status