oemof/oemof-solph

View on GitHub
src/oemof/solph/components/experimental/_sink_dsm.py

Summary

Maintainability
F
2 wks
Test Coverage

File _sink_dsm.py has 4619 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-

"""
Implementation of demand-side management (demand response) which allows for

Severity: Major
Found in src/oemof/solph/components/experimental/_sink_dsm.py - About 1 wk to fix

    Function __init__ has 31 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in src/oemof/solph/components/experimental/_sink_dsm.py - About 3 hrs to fix

      Function _old_dsm_capacity_rule_end has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

                  def _old_dsm_capacity_rule_end(block):
                      """Rule definition for determining old endogenously installed
                      capacity to be decommissioned due to reaching its lifetime.
                      Investment and decommissioning periods are linked within
                      the constraint. The respective decommissioning period is
      Severity: Minor
      Found in src/oemof/solph/components/experimental/_sink_dsm.py - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def __init__(
              self,
              demand,
              capacity_up,
              capacity_down,
      Severity: Minor
      Found in src/oemof/solph/components/experimental/_sink_dsm.py - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function __init__ has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def __init__(
              self,
              demand,
              capacity_up,
              capacity_down,
      Severity: Minor
      Found in src/oemof/solph/components/experimental/_sink_dsm.py - About 1 hr to fix

        Function _evaluate_remaining_value_difference has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def _evaluate_remaining_value_difference(
        Severity: Major
        Found in src/oemof/solph/components/experimental/_sink_dsm.py - About 50 mins to fix

          Function _evaluate_remaining_value_difference has 7 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def _evaluate_remaining_value_difference(
          Severity: Major
          Found in src/oemof/solph/components/experimental/_sink_dsm.py - About 50 mins to fix

            Function _evaluate_remaining_value_difference has 7 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def _evaluate_remaining_value_difference(
            Severity: Major
            Found in src/oemof/solph/components/experimental/_sink_dsm.py - About 50 mins to fix

              Function constraint_group has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def constraint_group(self):
                      possible_approaches = ["DIW", "DLR", "oemof"]
              
                      if not self.shed_eligibility and not self.shift_eligibility:
                          raise ValueError(
              Severity: Minor
              Found in src/oemof/solph/components/experimental/_sink_dsm.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              There are no issues that match your filters.

              Category
              Status