Sign upLogin

oglimmer/lunchy

View on GitHub
Star

Showing 111 of 111 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public String getIsBot() {
        JsonArray array = json.getJsonArray("app.bots");
        if (array != null) {
            return getRegExFromJsonArray(array);
        } else {
Severity: Minor
Found in src/main/java/de/oglimmer/lunchy/services/LunchyProperties.java and 1 other location - About 30 mins to fix
src/main/java/de/oglimmer/lunchy/services/LunchyProperties.java on lines 209..216

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    @SneakyThrows(value = SQLException.class)
    public List<Record> get(Timestamp from, int fkCommunity) {
        try (Connection conn = DBConn.INSTANCE.get()) {
            DSLContext create = DaoBackend.getContext(conn);
            return queryByDate(from, fkCommunity, create);
Severity: Minor
Found in src/main/java/de/oglimmer/lunchy/database/dao/UpdatesDao.java and 2 other locations - About 30 mins to fix
src/main/java/de/oglimmer/lunchy/database/dao/TagDao.java on lines 38..43
src/main/java/de/oglimmer/lunchy/database/dao/UpdatesDao.java on lines 37..43

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public String getIsNoBot() {
        JsonArray array = json.getJsonArray("app.no-bots");
        if (array != null) {
            return getRegExFromJsonArray(array);
        } else {
Severity: Minor
Found in src/main/java/de/oglimmer/lunchy/services/LunchyProperties.java and 1 other location - About 30 mins to fix
src/main/java/de/oglimmer/lunchy/services/LunchyProperties.java on lines 200..207

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    private Set<String> createSet(Integer fkOffice, int fkCommunity) throws SQLException {
        try (Connection conn = DBConn.INSTANCE.get()) {
            DSLContext create = DaoBackend.getContext(conn);
            return queryDatabase(fkOffice, fkCommunity, create);
        }
Severity: Minor
Found in src/main/java/de/oglimmer/lunchy/database/dao/TagDao.java and 2 other locations - About 30 mins to fix
src/main/java/de/oglimmer/lunchy/database/dao/UpdatesDao.java on lines 37..43
src/main/java/de/oglimmer/lunchy/database/dao/UpdatesDao.java on lines 45..51

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $scope.deleteInclTag = function(key) {
        $scope.data.exclTags = addTags($scope.data.exclTags, key);
    }
Severity: Minor
Found in src/main/webapp/js/index/controllers/LunchyControllerFinder.js and 1 other location - About 30 mins to fix
src/main/webapp/js/index/controllers/LunchyControllerFinder.js on lines 88..90

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $scope.deleteExclTag = function(key) {
        $scope.data.inclTags = addTags($scope.data.inclTags, key);
    }
Severity: Minor
Found in src/main/webapp/js/index/controllers/LunchyControllerFinder.js and 1 other location - About 30 mins to fix
src/main/webapp/js/index/controllers/LunchyControllerFinder.js on lines 84..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return ('' + obj).toLowerCase().indexOf(text) > -1;
Severity: Major
Found in src/main/webapp/js/services.js - About 30 mins to fix

    Method queryRandom has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        @GET
    @Produces(MediaType.APPLICATION_JSON)
    @Path("random")
    public List<QueryResponse> queryRandom(@Context HttpServletRequest request,
            @QueryParam(value = "inclTags") String inclTags, @QueryParam(value = "partner") String partner,
    Severity: Minor
    Found in src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method query has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        @GET
    @Produces(MediaType.APPLICATION_JSON)
    public List<QueryResponse> query(@Context HttpServletRequest request,
            @QueryParam(value = "inclTags") String inclTags, @QueryParam(value = "partner") String partner,
            @QueryParam(value = "maxTime") Integer maxTime, @QueryParam(value = "minRating") Integer minRating,
    Severity: Minor
    Found in src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getMinScoreForLoc has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private int getMinScoreForLoc(List<QueryResponse> possibleLoc, LocationResponse location) {
        for (QueryResponse qr : possibleLoc) {
            for (QueryResponseSectionLine qrsl : qr.getSectionLines()) {
                if (qrsl.getLocation() == location) {
                    return qr.getMinRating();
    Severity: Minor
    Found in src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method updateAndLogin has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        @POST
    @Produces(MediaType.APPLICATION_JSON)
    @Consumes(MediaType.APPLICATION_JSON)
    @Path("{id}")
    public LoginResponse updateAndLogin(@Context HttpServletRequest request, @PathParam("id") Integer id, UserUpdateInput input) {
    Severity: Minor
    Found in src/main/java/de/oglimmer/lunchy/rest/resources/UserResource.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language