Sign upLogin

oglimmer/lunchy

View on GitHub
Star
src/main/java/de/oglimmer/lunchy/image/ImageScaler.java

Summary

Maintainability
A
2 hrs
Test Coverage

Method fixRotation has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private BufferedImage fixRotation() throws IOException {
        BufferedImage tmpImg = originalImage;
        // http://sylvana.net/jpegcrop/exif_orientation.html
        switch (getOrientation(getBufferedInputStream())) {
        case 1:
Severity: Minor
Found in src/main/java/de/oglimmer/lunchy/image/ImageScaler.java - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            case 5:
            BufferedImage step1ImgB = Scalr.rotate(tmpImg, Scalr.Rotation.CW_90);
            tmpImg = Scalr.rotate(step1ImgB, Scalr.Rotation.FLIP_HORZ);
            break;
    Severity: Minor
    Found in src/main/java/de/oglimmer/lunchy/image/ImageScaler.java and 2 other locations - About 30 mins to fix
    src/main/java/de/oglimmer/lunchy/image/ImageScaler.java on lines 98..101
    src/main/java/de/oglimmer/lunchy/image/ImageScaler.java on lines 109..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            case 7:
            BufferedImage step1ImgC = Scalr.rotate(tmpImg, Scalr.Rotation.CW_270);
            tmpImg = Scalr.rotate(step1ImgC, Scalr.Rotation.FLIP_HORZ);
            break;
    Severity: Minor
    Found in src/main/java/de/oglimmer/lunchy/image/ImageScaler.java and 2 other locations - About 30 mins to fix
    src/main/java/de/oglimmer/lunchy/image/ImageScaler.java on lines 98..101
    src/main/java/de/oglimmer/lunchy/image/ImageScaler.java on lines 102..105

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            case 4:
            BufferedImage step1ImgA = Scalr.rotate(tmpImg, Scalr.Rotation.CW_180);
            tmpImg = Scalr.rotate(step1ImgA, Scalr.Rotation.FLIP_HORZ);
            break;
    Severity: Minor
    Found in src/main/java/de/oglimmer/lunchy/image/ImageScaler.java and 2 other locations - About 30 mins to fix
    src/main/java/de/oglimmer/lunchy/image/ImageScaler.java on lines 102..105
    src/main/java/de/oglimmer/lunchy/image/ImageScaler.java on lines 109..112

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status