Sign upLogin

oglimmer/lunchy

View on GitHub
Star
src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method queryRandom has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @GET
    @Produces(MediaType.APPLICATION_JSON)
    @Path("random")
    public List<QueryResponse> queryRandom(@Context HttpServletRequest request,
            @QueryParam(value = "inclTags") String inclTags, @QueryParam(value = "partner") String partner,
Severity: Minor
Found in src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java - About 1 hr to fix

    Method queryRandom has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public List<QueryResponse> queryRandom(@Context HttpServletRequest request,
            @QueryParam(value = "inclTags") String inclTags, @QueryParam(value = "partner") String partner,
            @QueryParam(value = "maxTime") Integer maxTime, @QueryParam(value = "minRating") Integer minRating,
            @QueryParam(value = "selectedOffice") Integer selectedOffice) {
    Severity: Minor
    Found in src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java - About 45 mins to fix

      Method query has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public List<QueryResponse> query(@Context HttpServletRequest request,
            @QueryParam(value = "inclTags") String inclTags, @QueryParam(value = "partner") String partner,
            @QueryParam(value = "maxTime") Integer maxTime, @QueryParam(value = "minRating") Integer minRating,
            @QueryParam(value = "selectedOffice") Integer selectedOffice) {
      Severity: Minor
      Found in src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java - About 45 mins to fix

        Method queryRandom has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            @GET
    @Produces(MediaType.APPLICATION_JSON)
    @Path("random")
    public List<QueryResponse> queryRandom(@Context HttpServletRequest request,
            @QueryParam(value = "inclTags") String inclTags, @QueryParam(value = "partner") String partner,
        Severity: Minor
        Found in src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method query has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            @GET
    @Produces(MediaType.APPLICATION_JSON)
    public List<QueryResponse> query(@Context HttpServletRequest request,
            @QueryParam(value = "inclTags") String inclTags, @QueryParam(value = "partner") String partner,
            @QueryParam(value = "maxTime") Integer maxTime, @QueryParam(value = "minRating") Integer minRating,
        Severity: Minor
        Found in src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method getMinScoreForLoc has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            private int getMinScoreForLoc(List<QueryResponse> possibleLoc, LocationResponse location) {
        for (QueryResponse qr : possibleLoc) {
            for (QueryResponseSectionLine qrsl : qr.getSectionLines()) {
                if (qrsl.getLocation() == location) {
                    return qr.getMinRating();
        Severity: Minor
        Found in src/main/java/de/oglimmer/lunchy/rest/resources/FinderResource.java - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status