Sign upLogin

okcashpro/okshop

View on GitHub
Star

Showing 130 of 130 total issues

Avoid too many return statements within this function.
Open

        return redirect('shop:cart')
Severity: Major
Found in shop/views.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return render(request, 'shop/checkout3.html', {'checkout': chkout})
    Severity: Major
    Found in shop/views.py - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              self.assertEquals(str(list(response.context['messages'])[0]),
                          'Welcome back, _u3!')
      Severity: Minor
      Found in shop/tests.py and 1 other location - About 30 mins to fix
      shop/tests.py on lines 136..137

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 32.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

              return self.outside_price
      Severity: Major
      Found in shop/models.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return -self.get_score()
        Severity: Major
        Found in shop/models.py - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  self.assertEquals(str(list(response.context['messages'])[0]),
                          'Welcome back, _u1!')
          Severity: Minor
          Found in shop/tests.py and 1 other location - About 30 mins to fix
          shop/tests.py on lines 176..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 32.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

                      return render(request, 'shop/checkout2.html',
          Severity: Major
          Found in shop/views.py - About 30 mins to fix

            Function get_key has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def get_key(request):
    if request.method == 'POST' and 'purchaseid' in request.POST and \
       'keyid' in request.POST:
        try:
            purchase = PurchaseItem.objects.get(purchase__by=request.user,
            Severity: Minor
            Found in shop/views.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function api_newwallet has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def api_newwallet(request):
    response = {'status': ""}
    errors = []
    if request.method == 'POST' and 'wallet_name' in request.POST:
        if len(request.POST['wallet_name']) > 30:
            Severity: Minor
            Found in shop/views.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_shipping_price has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def get_shipping_price(self):
        if not self.cached_shipping:
            s = 0
            for item in self.cart.cartentry_set.filter(
                    product__stock__gte=F('quantity'), product__physical=True):
            Severity: Minor
            Found in shop/models.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language