Sign upLogin

okfn-brasil/perfil-politico

View on GitHub
Star

Showing 12 of 12 total issues

Function api_fields has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def api_fields(self):
        """Define fields to select in the QuerySet based on preparer fields"""
        fields = ["year", "sequential"]
        methods = {
            "elections",
Severity: Minor
Found in perfil/core/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function age_stats has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def age_stats(self, data):
        aggregated = defaultdict(int)
        ordered = (
            "less-than-25",
            "between-25-and-34",
Severity: Minor
Found in perfil/core/views.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_politician has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def get_politician(name, post=None):
    name = name.upper()

    def get_match(qs, post=None):
        if post:
Severity: Minor
Found in perfil/core/management/commands/__init__.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function post_handle has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def post_handle(self):
        kwargs = {"desc": "Linking authorship", "unit": "bills"}
        for url, authors in tqdm(self.post_handle_cache.items(), **kwargs):
            bill = Bill.objects.get(url=url)
            for author in authors.split(","):
Severity: Minor
Found in perfil/core/management/commands/load_bills.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updated_politicians has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def updated_politicians(self):
        kwargs = {
            "total": len(self.suspicions_by_politician),
            "unit": "politicians",
            "desc": "Linking suspicions to politicians",
Severity: Minor
Found in perfil/core/management/commands/load_rosies_suspicions.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function state_stats has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def state_stats(request, state, year, post, characteristic):
Severity: Minor
Found in perfil/core/views.py - About 35 mins to fix

    Function get_candidate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    def get_candidate(year, state, sequential):
    kwargs = dict(year=year, state=state, sequential=sequential)
    candidates = tuple(Candidate.objects.filter(**kwargs))

    if len(candidates) == 1:  # yay, there's only match!
    Severity: Minor
    Found in perfil/core/management/commands/__init__.py - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                    return "between-60-and-69"
    Severity: Major
    Found in perfil/core/views.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return "70-or-more"
      Severity: Major
      Found in perfil/core/views.py - About 30 mins to fix

        Do not use bare 'except'
        Open

                except:
        Severity: Minor
        Found in perfil/middlewares/sqlprint.py by pep8

        When catching exceptions, mention specific exceptions when possible.

        Okay: except Exception:
Okay: except BaseException:
E722: except:

        Do not use bare 'except'
        Open

            except:
        Severity: Minor
        Found in perfil/middlewares/sqlprint.py by pep8

        When catching exceptions, mention specific exceptions when possible.

        Okay: except Exception:
Okay: except BaseException:
E722: except:

        Whitespace before ':'
        Open

                        sql = sql[width - indentation :]
        Severity: Minor
        Found in perfil/middlewares/sqlprint.py by pep8

        Avoid extraneous whitespace.

        Avoid extraneous whitespace in these situations:
- Immediately inside parentheses, brackets or braces.
- Immediately before a comma, semicolon, or colon.

Okay: spam(ham[1], {eggs: 2})
E201: spam( ham[1], {eggs: 2})
E201: spam(ham[ 1], {eggs: 2})
E201: spam(ham[1], { eggs: 2})
E202: spam(ham[1], {eggs: 2} )
E202: spam(ham[1 ], {eggs: 2})
E202: spam(ham[1], {eggs: 2 })

E203: if x == 4: print x, y; x, y = y , x
E203: if x == 4: print x, y ; x, y = y, x
E203: if x == 4 : print x, y; x, y = y, x
        Severity
        Category
        Status
        Source
        Language