Sign upLogin

okfn-brasil/serenata-de-amor

View on GitHub
Star
research/src/fetch_deputies_advisors.py

Summary

Maintainability
A
1 hr
Test Coverage

Function organize_deputy_data has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def organize_deputy_data(deputy, advisors):
    """
    Organizes all the deputies information in a list. Use this function to
    prepare data to be written to CSV format.
    :deputy: (dict) A dict with keys `deputy_name` and `deputy_number`
Severity: Minor
Found in research/src/fetch_deputies_advisors.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function send_requests has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def send_requests(reqs):
    """
    Send all the requests in :reqs: and reads the response data to extract the
    deputies data.  It will check if a deputy has more than one page of
    advisors and send new requests if True
Severity: Minor
Found in research/src/fetch_deputies_advisors.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status