Sign upLogin

olegskl/invasive-kanji

View on GitHub
Star

Showing 10 of 10 total issues

File framescript.js has 299 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*jslint browser: true, devel: true */
/*globals chrome, addEventHandlerCalledOnce, weightedEditDistance */

// -------------------------- Step-by-step procedure ---------------------------
// 1. Request a random dictionary entry from the background page;
Severity: Minor
Found in extension/js/framescript.js - About 3 hrs to fix

    Function parseLine has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function parseLine(line, options) {

    var grade, // placeholder for kanji grade
        meanings, // placeholder for a list of meanings of a given term
        readings, // placeholder for a list of readings of a given term
    Severity: Minor
    Found in datagen/convertor.js - About 1 hr to fix

      Function weightedEditDistance has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      function weightedEditDistance(a, b) {
    'use strict';

    var matrix = [], cost, i, j;
      Severity: Minor
      Found in extension/js/levenshtein.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function assemble has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function assemble(settings, callback) {
    var pending = 0, // keeps track of how many sources are being worked on
        errors = [], // container for errors
        assembly = []; // final assembly of dictionaries
      Severity: Minor
      Found in datagen/update.js - About 1 hr to fix

        Function parseLine has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

        function parseLine(line, options) {

    var grade, // placeholder for kanji grade
        meanings, // placeholder for a list of meanings of a given term
        readings, // placeholder for a list of readings of a given term
        Severity: Minor
        Found in datagen/convertor.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (entry.dictionary !== undefined &&
                    isArray(preferences.dictionaries) &&
                    preferences.dictionaries.indexOf(entry.dictionary) === -1) {
                return false;
            }
        Severity: Major
        Found in extension/js/background.js and 1 other location - About 1 hr to fix
        extension/js/background.js on lines 91..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (entry.grade !== undefined && isArray(preferences.grades) &&
                    preferences.grades.indexOf(entry.grade) === -1) {
                return false;
            }
        Severity: Major
        Found in extension/js/background.js and 1 other location - About 1 hr to fix
        extension/js/background.js on lines 86..90

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function addQuestion has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function addQuestion(question, callback) {
        var isFirstQuestion = !questions.length,
            nodes;

        // The question must be an object:
        Severity: Minor
        Found in extension/js/framescript.js - About 1 hr to fix

          Function stealFocus has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              function stealFocus(callback) {
        // Callback might be an event object:
        if (typeof callback !== 'function') {
            callback = noop;
        }
          Severity: Minor
          Found in extension/js/framescript.js - About 1 hr to fix

            Function weightedEditDistance has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function weightedEditDistance(a, b) {
    'use strict';

    var matrix = [], cost, i, j;
            Severity: Minor
            Found in extension/js/levenshtein.js - About 1 hr to fix
              Severity
              Category
              Status
              Source
              Language