Sign upLogin

oliverlorenz/phpMqttClient

View on GitHub
Star

Showing 7 of 7 total issues

Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Version $version,
        $username = null,
        $password = null,
        $clientId = null,
        $cleanSession = true,
Severity: Major
Found in src/packet/Connect.php - About 1 hr to fix

    Method publish has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function publish(Connection $stream, $topic, $message, $qos = 0, $dup = false, $retain = false)
    Severity: Minor
    Found in src/MqttClient.php - About 45 mins to fix

      Function getConnectFlags has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getConnectFlags()
    {
        $connectByte = 0;
        if ($this->cleanSession) {
            $connectByte += 1 << 1;
      Severity: Minor
      Found in src/packet/Connect.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return PublishReceived::parse($version, $input);
      Severity: Major
      Found in src/packet/Factory.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return PublishComplete::parse($version, $input);
        Severity: Major
        Found in src/packet/Factory.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return PublishRelease::parse($version, $input);
          Severity: Major
          Found in src/packet/Factory.php - About 30 mins to fix

            Function addReservedBitsToFixedHeaderControlPacketType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function addReservedBitsToFixedHeaderControlPacketType($byte1)
    {
        $qosByte = 0;
        if ($this->qos === 1) {
            $qosByte = 1;
            Severity: Minor
            Found in src/packet/Publish.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language