Sign upLogin

omidh28/clarifyjs

View on GitHub
Star

Showing 8 of 9 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  _sortListByPriority() {
    this._queue.sort((a, b) => {
      if (a.priority < b.priority) {
        return 1;
      }
Severity: Major
Found in src/callManager.js and 1 other location - About 2 hrs to fix
src/callManager.js on lines 96..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  _sortPassedArgumentsByPriority() {
    this._passedHandlerArgs.sort((a, b) => {
      if (a.priority < b.priority) {
        return 1;
      }
Severity: Major
Found in src/callManager.js and 1 other location - About 2 hrs to fix
src/callManager.js on lines 82..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 79.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function buildFrom has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  buildFrom(sourcePath) {
    const stateContainer = this._callManager._stateContainer;
    const finalPromise = stateContainer.finalPromise;
    stateContainer.resetFinalPromiseProperties();
    const builtChainedObject = {};
Severity: Minor
Found in src/builder.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _processNextItem has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _processNextItem(previousResult = null, storePreviousResultAs = '') {
    if (previousResult && storePreviousResultAs) {
      this._stateContainer.store(storePreviousResultAs, previousResult);
    }
Severity: Minor
Found in src/callManager.js - About 1 hr to fix

    Function buildFrom has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      buildFrom(sourcePath) {
    const stateContainer = this._callManager._stateContainer;
    const finalPromise = stateContainer.finalPromise;
    stateContainer.resetFinalPromiseProperties();
    const builtChainedObject = {};
    Severity: Minor
    Found in src/builder.js - About 1 hr to fix

      Function _processNextItem has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        _processNextItem(previousResult = null, storePreviousResultAs = '') {
    if (previousResult && storePreviousResultAs) {
      this._stateContainer.store(storePreviousResultAs, previousResult);
    }
      Severity: Minor
      Found in src/callManager.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validateArguments has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function validateArguments({
  path,
  handler,
  controller,
  inject,
      Severity: Minor
      Found in src/route.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getLevelOnePathsFrom has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        getLevelOnePathsFrom(sourcePath) {
    const allPathsFromSource = this.getAllPathsFrom(sourcePath);
    const pathsComponents = allPathsFromSource.map(path => Route.componentsOf(path));
    let levelOneComponents = pathsComponents.filter((componentsToCheck) => {
      return pathsComponents.every((components) => {
      Severity: Minor
      Found in src/blueprint.js - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language