omissis/goarkitect

View on GitHub

Showing 5 of 5 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (e haveContentMatchingRegex) getViolation(filePath string) rule.CoreViolation {
    format := "file '%s' does not have content matching regex '%s'"

    if e.options.matchSingleLines {
        format = "file '%s' does not have all lines matching regex '%s'"
Severity: Major
Found in internal/arch/file/expect/have_content_matching_regex.go and 1 other location - About 1 hr to fix
internal/arch/file/expect/have_content_matching.go on lines 66..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (e haveContentMatchingExpression) getViolation(filePath string) rule.CoreViolation {
    format := "file '%s' does not have content matching '%s'"

    if e.options.matchSingleLines {
        format = "file '%s' does not have all lines matching '%s'"
Severity: Major
Found in internal/arch/file/expect/have_content_matching.go and 1 other location - About 1 hr to fix
internal/arch/file/expect/have_content_matching_regex.go on lines 63..81

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method RuleBuilder.Because has 7 return statements (exceeds 4 allowed).
Open

func (rb *RuleBuilder) Because(b rule.Because) ([]rule.Violation, []error) {
    if rb.locked {
        rb.addLockError()

        return nil, rb.GetErrors()
Severity: Major
Found in internal/arch/file/rule.go - About 45 mins to fix

    Function ExecuteFileRule has 5 return statements (exceeds 4 allowed).
    Open

    func ExecuteFileRule(conf Rule) ([]rule.Violation, []error) {
        rb, err := createFileBuilder(conf)
        if err != nil {
            return nil, []error{err}
        }
    Severity: Major
    Found in internal/config/executor.go - About 35 mins to fix

      Method App.Run has 5 return statements (exceeds 4 allowed).
      Open

      func (a *App) Run() error {
          if err := a.flagSet.Parse(GetArgs(os.Args, 1)); err != nil {
              return fmt.Errorf("error parsing flags: %w", err)
          }
      
      
      Severity: Major
      Found in internal/cli/app.go - About 35 mins to fix
        Severity
        Category
        Status
        Source
        Language