onebeyond/onebeyond-studio-core

View on GitHub

Showing 368 of 368 total issues

Method CreateEntity has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static TableEntity CreateEntity(AuditEvent auditEntityEvent, JToken changes, bool expandValuesInTableColumns)
    {
        EnsureArg.IsNotNull(auditEntityEvent, nameof(auditEntityEvent));

        // Need to turn the identity into a string key (if is an int, pad to 10 digits)

    Method Build has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static Expression<Func<T, bool>>? Build(
            IReadOnlyDictionary<string, IReadOnlyCollection<string>> query,
            CombineTypes combineType = CombineTypes.AND)
        {
            EnsureArg.IsNotNull(query, nameof(query));

      Method GetEqualsExpressionForType has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static Expression GetEqualsExpressionForType(
              Expression propertyExpression,
              ConstantExpression someValue)
          {
              switch (propertyExpression.Type.IsEnum ? "Enum" : propertyExpression.Type.Name)

        Method EnsurePropertiesOverrideFuncAttrCache has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static Dictionary<string, AuditPropertyValueProviderAttribute> EnsurePropertiesOverrideFuncAttrCache(Type type)
            {
                if (!_propertiesOverrideFuncAttrCache.ContainsKey(type))
                {
                    var overrideProps = new Dictionary<string, AuditPropertyValueProviderAttribute>();

          Method ComplexReplacementCase has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              [Fact]
              public void ComplexReplacementCase()
              {
                  ITemplateRenderer renderer = new HandleBarsTemplateRenderer();
          
          
          Severity: Minor
          Found in src/OneBeyond.Studio.Crosscuts.Tests/HandleBarsTemplateTests.cs - About 1 hr to fix

            Method IsNumeric has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static bool IsNumeric(this Type type)
                {
                    EnsureArg.IsNotNull(type, nameof(type));
            
                    switch (Type.GetTypeCode(type))
            Severity: Minor
            Found in src/OneBeyond.Studio.Crosscuts/Reflection/TypeExtensions.cs - About 1 hr to fix

              Method Execute has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected override T Execute<T>(ISyncExecution<T> execution)
                  {
                      using (var saveChangesCall = InterceptSaveChangesCall(execution))
                      {
                          var entityDomainEvents = default(EntityDomainEventList);

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public IIncludes<TEntity, TNextChild> ThenInclude<TNextChild>(
                        Expression<Func<TChild, IEnumerable<TNextChild>>> navigation)
                        where TNextChild : class
                    {
                        return _includeFilter1 is null
                src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 141..154

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 94.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    public IIncludes<TEntity, TNextChild> ThenInclude<TNextChild>(
                        Expression<Func<TChild, IEnumerable<TNextChild>>> navigation)
                        where TNextChild : class
                    {
                        return _includeFilter1 is null
                src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 340..353

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 94.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    {
                        EnsureArg.IsNotNull(containerBuilder, nameof(containerBuilder));
                
                        containerBuilder.Register(
                                (componentContext) =>
                src/OneBeyond.Studio.Crosscuts/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 22..33
                src/OneBeyond.Studio.Infrastructure.Azure/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 61..72

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    {
                        EnsureArg.IsNotNull(containerBuilder, nameof(containerBuilder));
                
                        containerBuilder.Register(
                                (componentContext) =>
                src/OneBeyond.Studio.Infrastructure.Azure/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 28..39
                src/OneBeyond.Studio.Infrastructure.Azure/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 61..72

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                    {
                        EnsureArg.IsNotNull(containerBuilder, nameof(containerBuilder));
                
                        containerBuilder.Register(
                                (componentContext) =>
                src/OneBeyond.Studio.Crosscuts/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 22..33
                src/OneBeyond.Studio.Infrastructure.Azure/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 28..39

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 93.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method Throwing_When_Existing_Queue_With_Sessions_Accessed_Without_SessionId_In_Options has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    [TestMethod]
                    public async Task Throwing_When_Existing_Queue_With_Sessions_Accessed_Without_SessionId_In_Options()
                    {
                        if (_connectionString.IsNullOrEmpty())
                        {

                  Method MissingVariablesShouldBeRemoved has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      [Fact]
                      public void MissingVariablesShouldBeRemoved()
                      {
                          ITemplateRenderer renderer = new HandleBarsTemplateRenderer();
                  
                  
                  Severity: Minor
                  Found in src/OneBeyond.Studio.Crosscuts.Tests/HandleBarsTemplateTests.cs - About 1 hr to fix

                    Method ToEntityProperty has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static object ToEntityProperty(this JToken value)
                        {
                            switch (value.Type)
                            {
                                case JTokenType.Boolean:

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      using System;
                      using EnsureThat;
                      
                      namespace OneBeyond.Studio.EntityAuditing.Domain.Attributes;
                      
                      
                      src/OneBeyond.Studio.EntityAuditing/OneBeyond.Studio.EntityAuditing.Domain/Attributes/AuditPropertyValueAttribute.cs on lines 1..20

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 92.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                      using System;
                      using EnsureThat;
                      
                      namespace OneBeyond.Studio.EntityAuditing.Domain.Attributes;
                      
                      
                      src/OneBeyond.Studio.EntityAuditing/OneBeyond.Studio.EntityAuditing.Domain/Attributes/AuditPropertyNameAttribute.cs on lines 1..20

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 92.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          public static ContainerBuilder AddRabbitPubSubMessageQueueReceiver<TMessage>(
                              this ContainerBuilder containerBuilder,
                              RabbitPubSubMessageQueueReceiverOptions options)
                          {
                              EnsureArg.IsNotNull(containerBuilder, nameof(containerBuilder));
                      src/OneBeyond.Studio.Infrastructure.Azure/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 10..23
                      src/OneBeyond.Studio.Infrastructure.Azure/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 122..134

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 91.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          public static ContainerBuilder AddServiceBusMessageQueueReceiver<TMessage>(
                              this ContainerBuilder containerBuilder,
                              AzureMessageQueueOptions options)
                          {
                              EnsureArg.IsNotNull(containerBuilder, nameof(containerBuilder));
                      src/OneBeyond.Studio.Infrastructure.Azure/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 10..23
                      src/OneBeyond.Studio.Infrastructure.RabbitMQ/DependencyInjection/ContainerBuilderExtensions.cs on lines 46..58

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 91.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          public static ContainerBuilder AddAzureLargeMessageQueue<TMessage>(
                              this ContainerBuilder containerBuilder,
                              AzureLargeMessageQueueOptions options)
                          {
                              EnsureArg.IsNotNull(containerBuilder, nameof(containerBuilder));
                      src/OneBeyond.Studio.Infrastructure.Azure/MessageQueues/DependencyInjection/ContainerBuilderExtensions.cs on lines 122..134
                      src/OneBeyond.Studio.Infrastructure.RabbitMQ/DependencyInjection/ContainerBuilderExtensions.cs on lines 46..58

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 91.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Severity
                      Category
                      Status
                      Source
                      Language