Sign upLogin

onebeyond/onebeyond-studio-core

View on GitHub
Star

Showing 368 of 368 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public override IQueryable<TEntity> GetQuery()
    {
        var query = base.GetQuery();
        return _includeFilter1 is null
            ? query.IncludeFilter(_includeFilter2)
Severity: Minor
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 118..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    [IntegrationEventType(ThatHappenedTypeName)]
    [IntegrationEventVersion(1, 0)]
    public class ThatHappened_1_0 : IntegrationEvent
    {
        public ThatHappened_1_0(string stringValue, DateTimeOffset raisedAt)
Severity: Minor
Found in src/OneBeyond.Studio.Application.SharedKernel.Tests/IntegrationEvents/TestableIntegrationEvents.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.Application.SharedKernel.Tests/IntegrationEvents/TestableIntegrationEvents.cs on lines 12..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        switch (handlerExceptions.Count)
        {
            case 0:
                return;
Severity: Minor
Found in src/OneBeyond.Studio.Application.SharedKernel/DomainEvents/DIBasedPostSaveDomainEventDispatcher.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.Application.SharedKernel/IntegrationEvents/DIBasedIntegrationEventDispatcher.cs on lines 97..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (_tags
            .Any((tag) =>
                string.Compare(
                    tag.Description,
                    description,
Severity: Minor
Found in src/OneBeyond.Studio.DataAccess.EFCore.Tests/Entities/PurchaseOrders/PurchaseOrder.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.DataAccess.EFCore.Tests/Entities/PurchaseOrders/PurchaseOrder.cs on lines 30..38

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public async Task<IReadOnlyCollection<TResultDto>> ListAsync<TResultDto>(
        Expression<Func<TEntity, TResultDto>> projection,
        Expression<Func<TEntity, bool>>? filter = null,
        Paging? paging = null,
        IReadOnlyCollection<Sorting<TEntity>>? sortings = null,
Severity: Minor
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRORepository.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.Application.SharedKernel/Repositories/IRORepository.cs on lines 31..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        switch (handlerExceptions.Count)
        {
            case 0:
                return;
Severity: Minor
Found in src/OneBeyond.Studio.Application.SharedKernel/IntegrationEvents/DIBasedIntegrationEventDispatcher.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.Application.SharedKernel/DomainEvents/DIBasedPostSaveDomainEventDispatcher.cs on lines 86..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    [IntegrationEventType(ThisHappenedTypeName)]
    [IntegrationEventVersion(1, 1)]
    public class ThisHappened_1_1 : IntegrationEvent
    {
        public ThisHappened_1_1(int intValue, DateTimeOffset raisedAt)
Severity: Minor
Found in src/OneBeyond.Studio.Application.SharedKernel.Tests/IntegrationEvents/TestableIntegrationEvents.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.Application.SharedKernel.Tests/IntegrationEvents/TestableIntegrationEvents.cs on lines 62..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public override IQueryable<TEntity> GetQuery()
    {
        var query = base.GetQuery();
        return _includeFilter1 is null
            ? query.IncludeFilter(_includeFilter2)
Severity: Minor
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 317..323

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (_lines
            .Any((line) =>
                string.Compare(
                    line.ItemName,
                    itemName,
Severity: Minor
Found in src/OneBeyond.Studio.DataAccess.EFCore.Tests/Entities/PurchaseOrders/PurchaseOrder.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.DataAccess.EFCore.Tests/Entities/PurchaseOrders/PurchaseOrder.cs on lines 55..63

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    public async Task<IReadOnlyCollection<TEntity>> ListAsync(
        Expression<Func<TEntity, bool>>? filter = null,
        Includes<TEntity>? includes = null,
        Paging? paging = null,
        IReadOnlyCollection<Sorting<TEntity>>? sortings = null,
Severity: Minor
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRORepository.cs and 1 other location - About 30 mins to fix
src/OneBeyond.Studio.Application.SharedKernel/Repositories/IRORepository.cs on lines 17..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

            return false;
Severity: Major
Found in src/OneBeyond.Studio.Application.SharedKernel/Specifications/FilterExpressionBuilder.cs - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                    return TryConvertDateOnlyFromString(valueToken, out value);
    Severity: Major
    Found in src/OneBeyond.Studio.Application.SharedKernel/Specifications/FilterExpressionBuilder.cs - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return TryConvertGuidFromString(valueToken, out value);
      Severity: Major
      Found in src/OneBeyond.Studio.Application.SharedKernel/Specifications/FilterExpressionBuilder.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                                return getSmartEnumFromValueLambda.Compile();
        Severity: Major
        Found in src/OneBeyond.Studio.Application.SharedKernel/Specifications/FilterExpressionBuilder.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in src/OneBeyond.Studio.Application.SharedKernel/Specifications/FilterExpressionBuilder.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return true;
            Severity: Major
            Found in src/OneBeyond.Studio.Application.SharedKernel/Specifications/FilterExpressionBuilder.cs - About 30 mins to fix

              Similar blocks of code found in 5 locations. Consider refactoring.
              Open

                      Assert.IsTrue(integrationEventTypes.Any((integrationEventType) =>
            integrationEventType.TypeName == TestableIntegrationEvents.ThisHappenedTypeName
            && integrationEventType.Version == 1.4m
            && integrationEventType.ClrType == typeof(TestableIntegrationEvents.ThisHappened_1_4)));
              Severity: Major
              Found in src/OneBeyond.Studio.Application.SharedKernel.Tests/IntegrationEvents/IntegrationEventTypeRegistryTests.cs and 4 other locations - About 30 mins to fix
              src/OneBeyond.Studio.Application.SharedKernel.Tests/IntegrationEvents/IntegrationEventTypeRegistryTests.cs on lines 32..35
              src/OneBeyond.Studio.Application.SharedKernel.Tests/IntegrationEvents/IntegrationEventTypeRegistryTests.cs on lines 36..39
              src/OneBeyond.Studio.Application.SharedKernel.Tests/IntegrationEvents/IntegrationEventTypeRegistryTests.cs on lines 44..47
              src/OneBeyond.Studio.Application.SharedKernel.Tests/IntegrationEvents/IntegrationEventTypeRegistryTests.cs on lines 48..51

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      includes = includes.Include((some) => some.SomeProperty4)
            .ThenInclude((another) => another.AnotherProperty3)
            .ThenInclude((yetAnother) => yetAnother.YetAnotherProperty1);
              Severity: Major
              Found in src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs and 3 other locations - About 30 mins to fix
              src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs on lines 18..20
              src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs on lines 24..26
              src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs on lines 30..32

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      includes = includes.Include((some) => some.SomeProperty4)
            .ThenInclude((another) => another.AnotherProperty2)
            .ThenInclude((yetAnother) => yetAnother.YetAnotherProperty1);
              Severity: Major
              Found in src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs and 3 other locations - About 30 mins to fix
              src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs on lines 18..20
              src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs on lines 24..26
              src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs on lines 36..38

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      includes = includes.Include((some) => some.SomeProperty3)
            .ThenInclude((another) => another.AnotherProperty3)
            .ThenInclude((yetAnother) => yetAnother.YetAnotherProperty1);
              Severity: Major
              Found in src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs and 3 other locations - About 30 mins to fix
              src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs on lines 18..20
              src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs on lines 30..32
              src/OneBeyond.Studio.Application.SharedKernel.Tests/Specifications/CollectionTests.cs on lines 36..38

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language