Sign upLogin

onebeyond/onebeyond-studio-core

View on GitHub
Star
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs

Summary

Maintainability
B
6 hrs
Test Coverage

Method CompileDataAccessFunction has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static Action<TAggregateRoot> CompileDataAccessFunction(DataAccessPolicy<TAggregateRoot>? dataAccessPolicy)
    {
        var isDataAccessAllowed1 = dataAccessPolicy?.CanBeAccessedCriteria?.Compile();
        var isDataAccessAllowed2 = dataAccessPolicy?.CanBeAccessedFunction;
        if (isDataAccessAllowed1 is null
Severity: Minor
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public async Task CreateAsync(TAggregateRoot aggregateRoot, CancellationToken cancellationToken)
    {
        EnsureArg.IsNotNull(aggregateRoot, nameof(aggregateRoot));
        var ensureCreateDataAccessPolicy = await EnsureCreateDataAccessPolicy.Task.ConfigureAwait(false);
        ensureCreateDataAccessPolicy(aggregateRoot);
    Severity: Major
    Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs and 2 other locations - About 1 hr to fix
    src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs on lines 108..115
    src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs on lines 117..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public async Task UpdateAsync(TAggregateRoot aggregateRoot, CancellationToken cancellationToken)
    {
        EnsureArg.IsNotNull(aggregateRoot, nameof(aggregateRoot));
        var ensureUpdateDataAccessPolicy = await EnsureUpdateDataAccessPolicy.Task.ConfigureAwait(false);
        ensureUpdateDataAccessPolicy(aggregateRoot);
    Severity: Major
    Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs and 2 other locations - About 1 hr to fix
    src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs on lines 99..106
    src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs on lines 117..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public async Task DeleteAsync(TAggregateRoot aggregateRoot, CancellationToken cancellationToken)
    {
        EnsureArg.IsNotNull(aggregateRoot, nameof(aggregateRoot));
        var ensureDeleteDataAccessPolicy = await EnsureDeleteDataAccessPolicy.Task.ConfigureAwait(false);
        ensureDeleteDataAccessPolicy(aggregateRoot);
    Severity: Major
    Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs and 2 other locations - About 1 hr to fix
    src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs on lines 99..106
    src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs on lines 108..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        {
        var readDataAccessPolicy = await ReadDataAccessPolicy.Task.ConfigureAwait(false);
        var query = ApplyIncludes(DbSet.Value, includes);
        query = ApplyFiltering(query, filter);
        query = ApplyFiltering(query, readDataAccessPolicy?.CanBeAccessedCriteria);
    Severity: Major
    Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRWRepository.cs and 1 other location - About 1 hr to fix
    src/OneBeyond.Studio.DataAccess.EFCore/Repositories/BaseRORepository.cs on lines 136..142

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 96.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status