Sign upLogin

onebeyond/onebeyond-studio-core

View on GitHub
Star
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs

Summary

Maintainability
C
7 hrs
Test Coverage

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public IIncludes<TEntity, TChild> Include<TChild>(
        Expression<Func<TEntity, IReadOnlyCollection<TChild>>> navigation)
        where TChild : class
    {
        EnsureArg.IsNotNull(navigation, nameof(navigation));
Severity: Major
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs and 2 other locations - About 1 hr to fix
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 38..47
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 49..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public IIncludes<TEntity, TChild> Include<TChild>(
        Expression<Func<TEntity, IEnumerable<TChild>>> navigation)
        where TChild : class
    {
        EnsureArg.IsNotNull(navigation, nameof(navigation));
Severity: Major
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs and 2 other locations - About 1 hr to fix
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 49..58
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 60..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public IIncludes<TEntity, TChild> Include<TChild>(
        Expression<Func<TEntity, ICollection<TChild>>> navigation)
        where TChild : class
    {
        EnsureArg.IsNotNull(navigation, nameof(navigation));
Severity: Major
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs and 2 other locations - About 1 hr to fix
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 38..47
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 60..69

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 96.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    public IIncludes<TEntity, TNextChild> ThenInclude<TNextChild>(
        Expression<Func<TChild, ICollection<TNextChild>>> navigation)
        where TNextChild : class
        => ThenInclude(
            Expression.Lambda<Func<TChild, IEnumerable<TNextChild>>>(
Severity: Major
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs and 7 other locations - About 1 hr to fix
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 128..134
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 51..57
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 59..65
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 156..162
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 164..170
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 355..361
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 363..369

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

    public IIncludes<TEntity, TNextChild> ThenInclude<TNextChild>(
        Expression<Func<TChild, IReadOnlyCollection<TNextChild>>> navigation)
        where TNextChild : class
        => ThenInclude(
            Expression.Lambda<Func<TChild, IEnumerable<TNextChild>>>(
Severity: Major
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs and 7 other locations - About 1 hr to fix
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 120..126
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 51..57
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 59..65
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 156..162
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 164..170
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 355..361
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFPlusIncludes.cs on lines 363..369

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    {
        EnsureArg.IsNotNull(navigation, nameof(navigation));

        var query = _query1 is null
            ? _query2!.ThenInclude(navigation)
Severity: Minor
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs and 1 other location - About 55 mins to fix
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 97..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    {
        EnsureArg.IsNotNull(navigation, nameof(navigation));

        var query = _query1 is null
            ? _query2!.ThenInclude(navigation)
Severity: Minor
Found in src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs and 1 other location - About 55 mins to fix
src/OneBeyond.Studio.DataAccess.EFCore/Repositories/EFCoreIncludes.cs on lines 110..118

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status