onebeyond/onebeyond-studio-file-storage

View on GitHub

Showing 30 of 30 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    [TestMethod]
    public void TestWhitelistStrategySucceedsWhenContentTypeIsListedWithEmptySignatureList()
    {
        var options = new MimeTypeValidationOptions
        {
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 64..95
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 97..128
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 163..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 196.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    [TestMethod]
    public void TestBlacklistStrategyFailsWhenContentTypeIsListedWithEmptySignatureList()
    {
        var options = new MimeTypeValidationOptions
        {
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 64..95
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 97..128
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 130..161

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 196.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    [TestMethod]
    public void TestBlacklistStrategySucceedsWhenContentTypeIsNotListed()
    {
        var options = new MimeTypeValidationOptions
        {
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 64..95
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 130..161
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 163..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 196.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    [TestMethod]
    public void TestWhitelistStrategyFailsWhenContentTypeIsNotListed()
    {
        var options = new MimeTypeValidationOptions
        {
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 97..128
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 130..161
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 163..194

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 196.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    [TestMethod]
    public void TestWhitelistStrategySucceedsWhenContentTypeIsListedWithEmptyEntryInSignatureList()
    {
        var options = new MimeTypeValidationOptions
        {
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 229..260

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 194.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    [TestMethod]
    public void TestBlacklistStrategyFailsWhenContentTypeIsListedWithEmptyEntryInSignatureList()
    {
        var options = new MimeTypeValidationOptions
        {
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 196..227

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 194.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    [TestMethod]
    public void TestWhitelistStrategyFailsWhenListIsEmpty()
    {
        var options = new MimeTypeValidationOptions
        {
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 38..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 180.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    [TestMethod]
    public void TestBlacklistStrategySucceedsWhenListIsEmpty()
    {
        var options = new MimeTypeValidationOptions
        {
src/OneBeyond.Studio.FileStorage.Domain.Tests/MimeTypeValidationStrategyTests.cs on lines 12..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 180.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method DoCopyFileAsync has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected override async Task DoCopyFileAsync(
        FileRecord fromFileRecord,
        FileRecord toFileRecord,
        CancellationToken cancellationToken)
    {
Severity: Minor
Found in src/OneBeyond.Studio.FileStorage.Azure/AzureBlobFileStorage.cs - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public static void AddFileStorage(
            this IServiceCollection services,
            MimeTypeValidationOptions validationOptions,
            Action<IFileStorageBuilder> fileStorageBuilderAction)
        {
    src/OneBeyond.Studio.FileStorage.Infrastructure/DependencyInjection/ServiceCollectionExtensions.cs on lines 75..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public static void AddCloudStorage(
            this IServiceCollection services,
            MimeTypeValidationOptions validationOptions,
            Action<ICloudStorageBuilder> cloudStorageBuilderAction)
        {
    src/OneBeyond.Studio.FileStorage.Infrastructure/DependencyInjection/ServiceCollectionExtensions.cs on lines 34..48

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method DownloadFileContentsAsZipAsync has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public async Task<Stream> DownloadFileContentsAsZipAsync(
            IEnumerable<FileRecord> fileRecords,
            CancellationToken cancellationToken = default)
        {
            EnsureArg.IsNotNull(fileRecords, nameof(fileRecords));
    Severity: Minor
    Found in src/OneBeyond.Studio.FileStorage.Domain/FileStorageBase.cs - About 1 hr to fix

      Method GetSharedAccessUriFromContainer has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static Uri GetSharedAccessUriFromContainer(
              string blobFileId,
              CloudStorageAction action,
              BlobContainerClient containerClient,
              TimeSpan sharedAccessDuration)
      Severity: Minor
      Found in src/OneBeyond.Studio.FileStorage.Azure/Helpers/ContainerHelper.cs - About 1 hr to fix

        Method IsFileCoveredByOptions has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private bool IsFileCoveredByOptions(Func<byte[], int, int> getContentSignature, string mimeType)
            {
                var mimeTypeSignatures = ListSignaturesByMimeType(mimeType);
        
                if (!mimeTypeSignatures.Any())

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public static IFileStorageBuilder UseFileSystem(
                  this IFileStorageBuilder fileRepositoryBuilder,
                  FileSystemFileStorageOptions options)
              {
                  EnsureArg.IsNotNull(fileRepositoryBuilder, nameof(fileRepositoryBuilder));
          src/OneBeyond.Studio.FileStorage.Azure/DependencyInjection/ServiceCollectionExtensions.cs on lines 11..23
          src/OneBeyond.Studio.FileStorage.Azure/DependencyInjection/ServiceCollectionExtensions.cs on lines 25..37

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public static IFileStorageBuilder UseAzureBlobs(
                  this IFileStorageBuilder fileRepositoryBuilder,
                  AzureBlobFileStorageOptions options)
              {
                  EnsureArg.IsNotNull(fileRepositoryBuilder, nameof(fileRepositoryBuilder));
          src/OneBeyond.Studio.FileStorage.Azure/DependencyInjection/ServiceCollectionExtensions.cs on lines 25..37
          src/OneBeyond.Studio.FileStorage.FileSystem/DependencyInjection/ServiceCollectionExtensions.cs on lines 11..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public static ICloudStorageBuilder UseAzureBlobs(
                  this ICloudStorageBuilder cloudStorageBuilder,
                  AzureBlobCloudStorageOptions cloudStorageOptions)
              {
                  EnsureArg.IsNotNull(cloudStorageBuilder, nameof(cloudStorageBuilder));
          src/OneBeyond.Studio.FileStorage.Azure/DependencyInjection/ServiceCollectionExtensions.cs on lines 11..23
          src/OneBeyond.Studio.FileStorage.FileSystem/DependencyInjection/ServiceCollectionExtensions.cs on lines 11..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method TestBlacklistStrategyFailsWhenContentTypeIsListedWithEntryInSignatureList has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              [TestMethod]
              public void TestBlacklistStrategyFailsWhenContentTypeIsListedWithEntryInSignatureList()
              {
                  var options = new MimeTypeValidationOptions
                  {

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private static IServiceProvider ConfigureCloudServices(IConfiguration configuration)
                {
                    var serviceCollection = new ServiceCollection();
                    serviceCollection.AddCloudStorage((cloudStorageBuilder) =>
                        cloudStorageBuilder.UseAzureBlobs(configuration.GetOptions<AzureBlobCloudStorageOptions>("FileStorage:AzureStorageBlobs")
            Severity: Minor
            Found in src/OneBeyond.Studio.FileStorage.ConsoleApp/Program.cs and 1 other location - About 45 mins to fix
            src/OneBeyond.Studio.FileStorage.ConsoleApp/Program.cs on lines 81..90

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                private static IServiceProvider ConfigureFileServices(IConfiguration configuration)
                {
                    var serviceCollection = new ServiceCollection();
            
                    serviceCollection.AddFileStorage(
            Severity: Minor
            Found in src/OneBeyond.Studio.FileStorage.ConsoleApp/Program.cs and 1 other location - About 45 mins to fix
            src/OneBeyond.Studio.FileStorage.ConsoleApp/Program.cs on lines 92..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 74.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language