Sign upLogin

onebeyond/systemic-azure-bus

View on GitHub
Star

Showing 16 of 16 total issues

Function exports has 259 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = () => {
    let sbClient;
    let topicClientFactory;
    let queueClientFactory;
    let enqueuedItems = 0;
Severity: Major
Found in index.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = () => {
    let sbClient;
    let topicClientFactory;
    let queueClientFactory;
    let enqueuedItems = 0;
    Severity: Minor
    Found in index.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                return {
                // ServiceBusReceivedMessage
                deadLetterReason,
                deadLetterErrorDescription,
                lockToken,
    Severity: Major
    Found in index.js and 1 other location - About 4 hrs to fix
    index.js on lines 65..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                const {
                // ServiceBusReceivedMessage
                deadLetterReason,
                deadLetterErrorDescription,
                lockToken,
    Severity: Major
    Found in index.js and 1 other location - About 4 hrs to fix
    index.js on lines 93..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 115.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File index.js has 274 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint-disable no-await-in-loop */
const debug = require('debug')('systemic-azure-bus');
const zlib = require('zlib');
const { join } = require('path');
const requireAll = require('require-all');
    Severity: Minor
    Found in index.js - About 2 hrs to fix

      Function getMessageProperties has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              const getMessageProperties = brokeredMessage => {
            const {
                // ServiceBusReceivedMessage
                deadLetterReason,
                deadLetterErrorDescription,
      Severity: Minor
      Found in index.js - About 1 hr to fix

        Function subscribe has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                const subscribe = onError => (subscriptionId, handler) => {
            const { topic, subscription, errorHandling } = subscriptions[subscriptionId] || {};
            if (!topic || !subscription) throw new Error(`Data for subscription ${subscriptionId} non found!`);
            const receiver = topicClientFactory.createReceiver({ topic, subscription });
            const topicErrorStrategies = {
        Severity: Minor
        Found in index.js - About 1 hr to fix

          Function exports has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = sender => async (body, options = {}) => { // eslint-disable-line object-curly-newline
    const { label = '', contentEncoding, applicationProperties, scheduledEnqueueTimeUtc, ...messageFields } = options;
    const message = {
        label,
        subject: label,
          Severity: Minor
          Found in lib/operations/topics/publish.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function exports has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          module.exports = sbClient => {
    let registeredReceivers = [];
    let registeredSenders = [];

    const createSender = topic => {
          Severity: Minor
          Found in lib/clientFactories/topics.js - About 1 hr to fix

            Function exports has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = sbClient => {
    const registeredSenders = [];
    const registeredReceivers = [];

    const createSender = queue => {
            Severity: Minor
            Found in lib/clientFactories/queue.js - About 1 hr to fix

              Function exports has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              module.exports = sender => async (body, options = {}) => { // eslint-disable-line object-curly-newline
    const { label = '', contentEncoding, applicationProperties, scheduledEnqueueTimeUtc, ...messageFields } = options;
    const message = {
        label,
        subject: label,
              Severity: Minor
              Found in lib/operations/topics/publish.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    const createSender = topic => {
        debug(`Preparing connection to publish on topic ${topic}...`);

        const topicSender = sbClient.createSender(topic);
        registeredSenders.push(topicSender);
                Severity: Major
                Found in lib/clientFactories/topics.js and 1 other location - About 1 hr to fix
                lib/clientFactories/queue.js on lines 7..13

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    const createSender = queue => {
        debug(`Preparing connection to publish on queue ${queue}...`);

        const queueSender = sbClient.createSender(queue);
        registeredSenders.push(queueSender);
                Severity: Major
                Found in lib/clientFactories/queue.js and 1 other location - About 1 hr to fix
                lib/clientFactories/topics.js on lines 7..13

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 58.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Function onMessageHandler has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                            const onMessageHandler = async brokeredMessage => {
                try {
                    enqueuedItems++;
                    debug(`Enqueued items increase | ${enqueuedItems} items`);
                    debug(`Handling message on topic ${topic}`);
                Severity: Minor
                Found in index.js - About 1 hr to fix

                  Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  module.exports = sbClient => {
    let registeredReceivers = [];
    let registeredSenders = [];

    const createSender = topic => {
                  Severity: Minor
                  Found in lib/clientFactories/topics.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function exports has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  module.exports = sbClient => {
    const registeredSenders = [];
    const registeredReceivers = [];

    const createSender = queue => {
                  Severity: Minor
                  Found in lib/clientFactories/queue.js - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language