Sign upLogin

oneclickorgs/one-click-orgs

View on GitHub
Star
app/controllers/application_controller.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Class ApplicationController has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationController < ActionController::Base
  protect_from_forgery

  before_filter :ensure_set_up
  before_filter :ensure_organisation_exists
Severity: Minor
Found in app/controllers/application_controller.rb - About 3 hrs to fix

    Method generate_pdf has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def generate_pdf(filename='Download', options={})
    options = {
      :header_right => "Printed on #{Time.now.utc.to_s(:long_date)}",
      :header_line => true
    }.with_indifferent_access.merge(options)
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 1 hr to fix

      Method prepare_notifications has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        def prepare_notifications
    return unless current_user

    # If you have a notification you want to show the user, put the
    # logic in here, and the template in shared/notifications.
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method track_analytics_event has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def track_analytics_event(event_name, options={})
    return unless Rails.env.production? && OneClickOrgs::GoogleAnalytics.active?
    if options[:now]
      @analytics_events ||= []
      @analytics_events.push(event_name)
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method load_analytics_events_from_session has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def load_analytics_events_from_session
    return unless Rails.env.production? && OneClickOrgs::GoogleAnalytics.active?
    unless session[:analytics_events].blank?
      @analytics_events ||= []
      session[:analytics_events].dup.each do |event|
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status