Sign upLogin

oneclickorgs/one-click-orgs

View on GitHub
Star
app/models/constitution_wrapper.rb

Summary

Maintainability
D
2 days
Test Coverage

Method update_attributes has a Cognitive Complexity of 91 (exceeds 5 allowed). Consider refactoring.
Open

  def update_attributes(options={})
    case organisation
    when Association
      organisation.clauses.set_text!('organisation_name', options[:organisation_name]) if organisation_name != options[:organisation_name]
Severity: Minor
Found in app/models/constitution_wrapper.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_attributes has 93 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def update_attributes(options={})
    case organisation
    when Association
      organisation.clauses.set_text!('organisation_name', options[:organisation_name]) if organisation_name != options[:organisation_name]
Severity: Major
Found in app/models/constitution_wrapper.rb - About 3 hrs to fix

    Method after_initialize has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def after_initialize
    # TODO ? only use constitution's original values as defaults; allow
    # new values to be passed in via the attributes
    case organisation
    when Association
    Severity: Minor
    Found in app/models/constitution_wrapper.rb - About 1 hr to fix

      Method after_initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def after_initialize
    # TODO ? only use constitution's original values as defaults; allow
    # new values to be passed in via the attributes
    case organisation
    when Association
      Severity: Minor
      Found in app/models/constitution_wrapper.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status