Sign upLogin

oneclickorgs/one-click-orgs

View on GitHub
Star
app/models/coop.rb

Summary

Maintainability
F
3 days
Test Coverage

Class Coop has 102 methods (exceeds 20 allowed). Consider refactoring.
Open

class Coop < Organisation
  # http://www.legislation.gov.uk/ukpga/2014/14/part/2/crossheading/maximum-shareholding/enacted
  MAXIMUM_SHAREHOLDING_IN_POUNDS = 100_000

  include OneClickOrgs::CastToBoolean
Severity: Major
Found in app/models/coop.rb - About 1 day to fix

    File coop.rb has 590 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'one_click_orgs/cast_to_boolean'

class Coop < Organisation
  # http://www.legislation.gov.uk/ukpga/2014/14/part/2/crossheading/maximum-shareholding/enacted
  MAXIMUM_SHAREHOLDING_IN_POUNDS = 100_000
    Severity: Major
    Found in app/models/coop.rb - About 1 day to fix

      Method create_default_member_classes has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def create_default_member_classes
    members = member_classes.find_or_create_by_name('Member')
    members.set_permission!(:resolution_proposal, true)
    members.set_permission!(:vote, true)
      Severity: Minor
      Found in app/models/coop.rb - About 1 hr to fix

        Method run_daily_job has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.run_daily_job
    # Find all Coop members who have not attained the minimum shareholding within 12 months
    # of membership.
    all.each do |coop|
      if !coop.single_shareholding && coop.minimum_shareholding
        Severity: Minor
        Found in app/models/coop.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method can_propose? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def can_propose?
    result = true

    result &&= members.active.count >= 3
    result &&= directors.count >= 3
        Severity: Minor
        Found in app/models/coop.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          state_machine :initial => :pending do
    event :propose do
      transition :pending => :proposed
    end
        Severity: Minor
        Found in app/models/coop.rb and 1 other location - About 30 mins to fix
        app/models/association.rb on lines 2..16

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status