app/models/member.rb
Class Member
has 21 methods (exceeds 20 allowed). Consider refactoring. Open
Open
class Member < ActiveRecord::Base
attr_accessible :email, :first_name, :last_name, :role, :terms_and_conditions,
:password, :password_confirmation, :send_welcome,
:address, :certify_share_application, :certify_age,
:phone, :member_class_id
Method cast_vote
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def cast_vote(action, proposal)
raise ArgumentError, "need action and proposal" unless action and proposal
existing_vote = Vote.where(:member_id => self.id, :proposal_id => proposal.id).first
raise VoteError, "Vote already exists for this proposal" if existing_vote
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"