Sign upLogin

onejgordon/flow-dashboard

View on GitHub
Star
services/goodreads.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function get_books_on_shelf has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

def get_books_on_shelf(user, shelf='currently-reading'):
    '''
    Return JSON array {title, author, isbn, image}
    '''
    user_id = user.get_integration_prop('goodreads_user_id')
Severity: Minor
Found in services/goodreads.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if name is not None:
                        author = name.text
                r = Readable.CreateOrUpdate(user, isbn, title=title,
Severity: Major
Found in services/goodreads.py - About 45 mins to fix

    There are no issues that match your filters.

    Category
    Status