onionskin/onionskin

View on GitHub

Showing 10 of 10 total issues

Function delete has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

IndexedDB.prototype.delete = function (key) {
  return this._key(key).then(function (k) {
    return this.db().then(function (db) {
      var transaction = db.transaction('cache', 'readwrite');
      var store = transaction.objectStore('cache');
Severity: Minor
Found in src/onionskin/drivers/indexed_db.js - About 1 hr to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      return new Promise(function (resolve) {
        that.pool.drivers.forEach(function (d) {
          d.unlock(that.key).then(resolve);
        });
      });
    Severity: Major
    Found in src/onionskin/item.js and 2 other locations - About 1 hr to fix
    src/onionskin/item.js on lines 153..157
    src/onionskin/item.js on lines 168..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      return new Promise(function (resolve) {
        that.pool.drivers.forEach(function (driver) {
          driver.delete(that.key).then(resolve);
        });
      });
    Severity: Major
    Found in src/onionskin/item.js and 2 other locations - About 1 hr to fix
    src/onionskin/item.js on lines 168..172
    src/onionskin/item.js on lines 206..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

      return new Promise(function (resolve) {
        that.pool.drivers.forEach(function (d) {
          d.lock(that.key).then(resolve);
        });
      });
    Severity: Major
    Found in src/onionskin/item.js and 2 other locations - About 1 hr to fix
    src/onionskin/item.js on lines 153..157
    src/onionskin/item.js on lines 206..210

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function IndexedDB has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function IndexedDB(namespace) {
      this.namespace = namespace || 'onionskin';
    
      this.indexedDB = window.indexedDB ||
        window.mozIndexedDB ||
    Severity: Minor
    Found in src/onionskin/drivers/indexed_db.js - About 1 hr to fix

      Function get has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Pool.prototype.get = function (key, cachePolicy, policyData, generator) {
        var item = this.getItem(key);
      
        if (typeof cachePolicy === 'function') {
          generator = cachePolicy;
      Severity: Minor
      Found in src/onionskin/pool.js - About 1 hr to fix

        Function get has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        Item.prototype.get = function (cachePolicy, policyData) {
          var that = this;
          this.cachePolicy = cachePolicy || Item.CP_NONE;
          this.policyData = policyData;
        
        
        Severity: Minor
        Found in src/onionskin/item.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          Memcached.available = (function () {
            try {
              require.resolve('memcached');
              return true;
            } catch (err) {
          Severity: Minor
          Found in src/onionskin/drivers/memcached.js and 1 other location - About 45 mins to fix
          src/onionskin/drivers/redis.js on lines 17..24

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          Redis.available = (function () {
            try {
              require.resolve('redis');
              return true;
            } catch (err) {
          Severity: Minor
          Found in src/onionskin/drivers/redis.js and 1 other location - About 45 mins to fix
          src/onionskin/drivers/memcached.js on lines 16..23

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function isMiss has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          Item.prototype.isMiss = function () {
            var that = this;
          
            var isMissed = function (locked, resolve) {
              var miss;
          Severity: Minor
          Found in src/onionskin/item.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language