Sign upLogin

onlyurei/knockout-spa

View on GitHub
Star

Showing 113 of 113 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  var serialize = function (value) {
    try {
      return JSON.stringify(value);
    } catch (e) {
      if (window.console) {
Severity: Major
Found in util/storage.js and 1 other location - About 1 hr to fix
util/storage.js on lines 10..18

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  }, deserialize = function (value) {
    try {
      return JSON.parse(value);
    } catch (e) {
      if (window.console) {
Severity: Major
Found in util/storage.js and 1 other location - About 1 hr to fix
util/storage.js on lines 2..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function init has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    init: function (name, data, path, controller) {
      this.loading = false;

      name = name.toLowerCase();
Severity: Minor
Found in framework/page.js - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

        if (href && !href.startsWith('#') && ((origin === window.location.origin) || !origin) &&
        ($(this).attr('target') != '_blank') && !$(this).data('go') && !event.ctrlKey && !event.metaKey) {
      event.preventDefault();
      Page.loading = true;
      router.setRoute(href);
    Severity: Critical
    Found in framework/router.js - About 1 hr to fix

      Function constructor has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          constructor: function (inputs, submit, initFromQueryString) {
      this.inputs = {};
      if (Object.isObject(inputs)) {
        this.inputs = inputs;
      } else if (Object.isArray(inputs)) {
      Severity: Minor
      Found in widget/form/form.js - About 1 hr to fix

        Function getCurrentPosition has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getCurrentPosition: function (successCallback, errCallback) {
      if (this.geolocationAvailable) {
        this.gettingCurrentPosition(true);
        this.currentPosition(null);
        navigator.geolocation.getCurrentPosition(
        Severity: Minor
        Found in widget/form/form-input-location.js - About 1 hr to fix

          Function flatten has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function flatten(object) {
    var result = {};

    function recurse(cur, prop) {
      if (Object(cur) !== cur) {
          Severity: Minor
          Found in util/json.js - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                  if (Object.isObject(synchronousOrSocket)) {

        var deferred = $.Deferred();

        require(['io'], function (io) {
            Severity: Major
            Found in app/shared/api/api.js - About 1 hr to fix

              Function constructor has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    name, value, required, validations, useCurrentPosition, submitOnChange, initFromQueryString, autocomplete) {
              Severity: Major
              Found in widget/form/form-input-location.js - About 1 hr to fix

                Function call has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    call: function (apiPackage, apiMethod, urlParams, data, error, loading, synchronousOrSocket) {
                Severity: Major
                Found in app/shared/api/api.js - About 50 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      fromQueryString: function (queryString) {
      Object.each(this.inputs, function (name, input) {
        input.fromQueryString(queryString);
      });
      return this.inputs;
                  Severity: Minor
                  Found in widget/form/form.js and 1 other location - About 50 mins to fix
                  widget/form/form.js on lines 68..73

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      deserialize: function (json) {
      Object.each(this.inputs, function (name, input) {
        input.deserialize(json);
      });
      return this.inputs;
                  Severity: Minor
                  Found in widget/form/form.js and 1 other location - About 50 mins to fix
                  widget/form/form.js on lines 74..79

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 52.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function constructor has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      constructor: function (name, value, required, validations, submitOnChange, initFromQueryString) {
                  Severity: Minor
                  Found in widget/form/form-input.js - About 45 mins to fix

                    Function getDistanceFromLatLon has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        getDistanceFromLatLon: function (latitude1, longitude1, latitude2, longitude2, metric) {
                    Severity: Minor
                    Found in util/geolocation.js - About 35 mins to fix

                      Function makeErrorJson has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                        function makeErrorJson(message, file, line, column, error) {
                      Severity: Minor
                      Found in util/error-reporter.js - About 35 mins to fix

                        Function onerror has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                          window.onerror = function (message, file, line, column, error) {
                        Severity: Minor
                        Found in util/error-reporter.js - About 35 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return false;
                          Severity: Major
                          Found in widget/form/form-input.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                      return ajax;
                            Severity: Major
                            Found in app/shared/api/api.js - About 30 mins to fix

                              Fallback color (hex or RGB) should precede RGBA color.
                              Open

                                color: rgba(0, 0, 0, 0.87);
                              Severity: Minor
                              Found in app/resources/resources.css by csslint

                              Adjoining classes: page-source-display .language-marker.html
                              Open

                              page-source-display .language-marker.html {
                              Severity: Minor
                              Found in component/page-source-display/page-source-display.css by csslint
                              Severity
                              Category
                              Status
                              Source
                              Language