onlyurei/todomvc-knockout-spa

View on GitHub

Showing 24 of 24 total issues

Method 'init' has a complexity of 8.
Open

        init: function (name, data, path, controller) {
Severity: Minor
Found in framework/page.js by eslint

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Function has a complexity of 7.
Open

            Object.each(page, function (key, value) {
Severity: Minor
Found in framework/page-disposer.js by eslint

Limit Cyclomatic Complexity (complexity)

Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

Rule Details

This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

Examples of incorrect code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

Examples of correct code for a maximum of 2:

/*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

Options

Optionally, you may specify a max object property:

"complexity": ["error", 2]

is equivalent to

"complexity": ["error", { "max": 2 }]

Deprecated: the object property maximum is deprecated. Please use the property max instead.

When Not To Use It

If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

Further Reading

Related Rules

  • [max-depth](max-depth.md)
  • [max-len](max-len.md)
  • [max-nested-callbacks](max-nested-callbacks.md)
  • [max-params](max-params.md)
  • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

Function init has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        init: function (name, data, path, controller) {
            this.loading = false;

            name = name.toLowerCase();

Severity: Minor
Found in framework/page.js - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if (href && !href.startsWith('#') && ((origin === window.location.origin) || !origin) &&
                ($(this).attr('target') != '_blank') && !$(this).data('go') && !event.ctrlKey && !event.metaKey) {
                event.preventDefault();
                Page.loading = true;
                router.setRoute(href);
    Severity: Critical
    Found in framework/router.js - About 1 hr to fix

      Function constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              constructor: function (params) {
                  this.filter = params.filter;
                  this.storageKey = params.storageKey || 'todos';
                  try {
                      this.models =
      Severity: Minor
      Found in component/todo-list/todo-list.js - About 1 hr to fix

        The body of a for-in should be wrapped in an if statement to filter unwanted properties from the prototype.
        Open

                    for (var prop in this.model) {
        Severity: Minor
        Found in component/todo-item/todo-item.js by eslint

        Require Guarding for-in (guard-for-in)

        Looping over objects with a for in loop will include properties that are inherited through the prototype chain. This behavior can lead to unexpected items in your for loop.

        for (key in foo) {
            doSomething(key);
        }

        Note that simply checking foo.hasOwnProperty(key) is likely to cause an error in some cases; see [no-prototype-builtins](no-prototype-builtins.md).

        Rule Details

        This rule is aimed at preventing unexpected behavior that could arise from using a for in loop without filtering the results in the loop. As such, it will warn when for in loops do not filter their results with an if statement.

        Examples of incorrect code for this rule:

        /*eslint guard-for-in: "error"*/
        
        for (key in foo) {
            doSomething(key);
        }

        Examples of correct code for this rule:

        /*eslint guard-for-in: "error"*/
        
        for (key in foo) {
            if (Object.prototype.hasOwnProperty.call(foo, key)) {
                doSomething(key);
            }
            if ({}.hasOwnProperty.call(foo, key)) {
                doSomething(key);
            }
        }

        Related Rules

        • [no-prototype-builtins](no-prototype-builtins.md)

        Further Reading

        Expected '!==' and instead saw '!='.
        Open

                    ($(this).attr('target') != '_blank') && !$(this).data('go') && !event.ctrlKey && !event.metaKey) {
        Severity: Minor
        Found in framework/router.js by eslint

        Require === and !== (eqeqeq)

        It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

        The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

        • [] == false
        • [] == ![]
        • 3 == "03"

        If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

        Rule Details

        This rule is aimed at eliminating the type-unsafe equality operators.

        Examples of incorrect code for this rule:

        /*eslint eqeqeq: "error"*/
        
        if (x == 42) { }
        
        if ("" == text) { }
        
        if (obj.getStuff() != undefined) { }

        The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

        Options

        always

        The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

        Examples of incorrect code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a == b
        foo == true
        bananas != 1
        value == undefined
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        Examples of correct code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a === b
        foo === true
        bananas !== 1
        value === undefined
        typeof foo === 'undefined'
        'hello' !== 'world'
        0 === 0
        true === true
        foo === null

        This rule optionally takes a second argument, which should be an object with the following supported properties:

        • "null": Customize how this rule treats null literals. Possible values:
          • always (default) - Always use === or !==.
          • never - Never use === or !== with null.
          • ignore - Do not apply this rule to null.

        smart

        The "smart" option enforces the use of === and !== except for these cases:

        • Comparing two literal values
        • Evaluating the value of typeof
        • Comparing against null

        Examples of incorrect code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        // comparing two variables requires ===
        a == b
        
        // only one side is a literal
        foo == true
        bananas != 1
        
        // comparing to undefined requires ===
        value == undefined

        Examples of correct code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        allow-null

        Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

        ["error", "always", {"null": "ignore"}]

        When Not To Use It

        If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

        Expected '!==' and instead saw '!='.
        Open

                    if ((tagNameLower.indexOf('-') != -1) || (String(node) == '[object HTMLUnknownElement]') ||
        Severity: Minor
        Found in lib-ext/knockout-extended.js by eslint

        Require === and !== (eqeqeq)

        It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

        The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

        • [] == false
        • [] == ![]
        • 3 == "03"

        If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

        Rule Details

        This rule is aimed at eliminating the type-unsafe equality operators.

        Examples of incorrect code for this rule:

        /*eslint eqeqeq: "error"*/
        
        if (x == 42) { }
        
        if ("" == text) { }
        
        if (obj.getStuff() != undefined) { }

        The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

        Options

        always

        The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

        Examples of incorrect code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a == b
        foo == true
        bananas != 1
        value == undefined
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        Examples of correct code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a === b
        foo === true
        bananas !== 1
        value === undefined
        typeof foo === 'undefined'
        'hello' !== 'world'
        0 === 0
        true === true
        foo === null

        This rule optionally takes a second argument, which should be an object with the following supported properties:

        • "null": Customize how this rule treats null literals. Possible values:
          • always (default) - Always use === or !==.
          • never - Never use === or !== with null.
          • ignore - Do not apply this rule to null.

        smart

        The "smart" option enforces the use of === and !== except for these cases:

        • Comparing two literal values
        • Evaluating the value of typeof
        • Comparing against null

        Examples of incorrect code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        // comparing two variables requires ===
        a == b
        
        // only one side is a literal
        foo == true
        bananas != 1
        
        // comparing to undefined requires ===
        value == undefined

        Examples of correct code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        allow-null

        Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

        ["error", "always", {"null": "ignore"}]

        When Not To Use It

        If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

        Expected an assignment or function call and instead saw an expression.
        Open

                        this.initExtra &&
        Severity: Minor
        Found in framework/page.js by eslint

        Disallow Unused Expressions (no-unused-expressions)

        An unused expression which has no effect on the state of the program indicates a logic error.

        For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

        Rule Details

        This rule aims to eliminate unused expressions which have no effect on the state of the program.

        This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

        var i = 0;
        function increment() { i += 1; }
        increment(); // return value is unused, but i changed as a side effect
        
        var nThings = 0;
        function Thing() { nThings += 1; }
        new Thing(); // constructed object is unused, but nThings changed as a side effect

        This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

        Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

        Options

        This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

        • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
        • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
        • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

        These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

        Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

        /*eslint no-unused-expressions: "error"*/
        
        0
        
        if(0) 0
        
        {0}
        
        f(0), {}
        
        a && b()
        
        a, b()
        
        c = a, b;
        
        a() && function namedFunctionInExpressionContext () {f();}
        
        (function anIncompleteIIFE () {});
        
        injectGlobal`body{ color: red; }`

        Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

        "use strict";
        "use asm"
        "use stricter";
        "use babel"
        "any other strings like this in the prologue";

        Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

        /*eslint no-unused-expressions: "error"*/
        
        {} // In this context, this is a block statement, not an object literal
        
        {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
        
        function namedFunctionDeclaration () {}
        
        (function aGenuineIIFE () {}());
        
        f()
        
        a = 0
        
        new C
        
        delete a.b
        
        void a

        allowShortCircuit

        Examples of incorrect code for the { "allowShortCircuit": true } option:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
        
        a || b

        Examples of correct code for the { "allowShortCircuit": true } option:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
        
        a && b()
        a() || (b = c)

        allowTernary

        Examples of incorrect code for the { "allowTernary": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
        
        a ? b : 0
        a ? b : c()

        Examples of correct code for the { "allowTernary": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
        
        a ? b() : c()
        a ? (b = c) : d()

        allowShortCircuit and allowTernary

        Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
        
        a ? b() || (c = d) : e()

        allowTaggedTemplates

        Examples of incorrect code for the { "allowTaggedTemplates": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
        
        `some untagged template string`;

        Examples of correct code for the { "allowTaggedTemplates": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
        
        tag`some tagged template string`;

        Source: http://eslint.org/docs/rules/

        Unexpected require().
        Open

                require(['framework/router']);
        Severity: Minor
        Found in app.js by eslint

        Enforce require() on the top-level module scope (global-require)

        In Node.js, module dependencies are included using the require() function, such as:

        var fs = require("fs");

        While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

        function foo() {
        
            if (condition) {
                var fs = require("fs");
            }
        }

        Since require() does a synchronous load, it can cause performance problems when used in other locations.

        Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

        Rule Details

        This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

        Examples of incorrect code for this rule:

        /*eslint global-require: "error"*/
        /*eslint-env es6*/
        
        // calling require() inside of a function is not allowed
        function readFile(filename, callback) {
            var fs = require('fs');
            fs.readFile(filename, callback)
        }
        
        // conditional requires like this are also not allowed
        if (DEBUG) { require('debug'); }
        
        // a require() in a switch statement is also flagged
        switch(x) { case '1': require('1'); break; }
        
        // you may not require() inside an arrow function body
        var getModule = (name) => require(name);
        
        // you may not require() inside of a function body as well
        function getModule(name) { return require(name); }
        
        // you may not require() inside of a try/catch block
        try {
            require(unsafeModule);
        } catch(e) {
            console.log(e);
        }

        Examples of correct code for this rule:

        /*eslint global-require: "error"*/
        
        // all these variations of require() are ok
        require('x');
        var y = require('y');
        var z;
        z = require('z').initialize();
        
        // requiring a module and using it in a function is ok
        var fs = require('fs');
        function readFile(filename, callback) {
            fs.readFile(filename, callback)
        }
        
        // you can use a ternary to determine which module to require
        var logger = DEBUG ? require('dev-logger') : require('logger');
        
        // if you want you can require() at the end of your module
        function doSomethingA() {}
        function doSomethingB() {}
        var x = require("x"),
            z = require("z");

        When Not To Use It

        If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

        Expected '===' and instead saw '=='.
        Open

                    if ((this.page.name == name) && (this.page.data == data)) {
        Severity: Minor
        Found in framework/page.js by eslint

        Require === and !== (eqeqeq)

        It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

        The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

        • [] == false
        • [] == ![]
        • 3 == "03"

        If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

        Rule Details

        This rule is aimed at eliminating the type-unsafe equality operators.

        Examples of incorrect code for this rule:

        /*eslint eqeqeq: "error"*/
        
        if (x == 42) { }
        
        if ("" == text) { }
        
        if (obj.getStuff() != undefined) { }

        The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

        Options

        always

        The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

        Examples of incorrect code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a == b
        foo == true
        bananas != 1
        value == undefined
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        Examples of correct code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a === b
        foo === true
        bananas !== 1
        value === undefined
        typeof foo === 'undefined'
        'hello' !== 'world'
        0 === 0
        true === true
        foo === null

        This rule optionally takes a second argument, which should be an object with the following supported properties:

        • "null": Customize how this rule treats null literals. Possible values:
          • always (default) - Always use === or !==.
          • never - Never use === or !== with null.
          • ignore - Do not apply this rule to null.

        smart

        The "smart" option enforces the use of === and !== except for these cases:

        • Comparing two literal values
        • Evaluating the value of typeof
        • Comparing against null

        Examples of incorrect code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        // comparing two variables requires ===
        a == b
        
        // only one side is a literal
        foo == true
        bananas != 1
        
        // comparing to undefined requires ===
        value == undefined

        Examples of correct code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        allow-null

        Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

        ["error", "always", {"null": "ignore"}]

        When Not To Use It

        If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

        Expected '===' and instead saw '=='.
        Open

                if (((location.protocol == 'http:') && (port == '80')) ||
        Severity: Minor
        Found in util/dom.js by eslint

        Require === and !== (eqeqeq)

        It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

        The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

        • [] == false
        • [] == ![]
        • 3 == "03"

        If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

        Rule Details

        This rule is aimed at eliminating the type-unsafe equality operators.

        Examples of incorrect code for this rule:

        /*eslint eqeqeq: "error"*/
        
        if (x == 42) { }
        
        if ("" == text) { }
        
        if (obj.getStuff() != undefined) { }

        The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

        Options

        always

        The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

        Examples of incorrect code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a == b
        foo == true
        bananas != 1
        value == undefined
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        Examples of correct code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a === b
        foo === true
        bananas !== 1
        value === undefined
        typeof foo === 'undefined'
        'hello' !== 'world'
        0 === 0
        true === true
        foo === null

        This rule optionally takes a second argument, which should be an object with the following supported properties:

        • "null": Customize how this rule treats null literals. Possible values:
          • always (default) - Always use === or !==.
          • never - Never use === or !== with null.
          • ignore - Do not apply this rule to null.

        smart

        The "smart" option enforces the use of === and !== except for these cases:

        • Comparing two literal values
        • Evaluating the value of typeof
        • Comparing against null

        Examples of incorrect code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        // comparing two variables requires ===
        a == b
        
        // only one side is a literal
        foo == true
        bananas != 1
        
        // comparing to undefined requires ===
        value == undefined

        Examples of correct code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        allow-null

        Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

        ["error", "always", {"null": "ignore"}]

        When Not To Use It

        If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

        Expected an assignment or function call and instead saw an expression.
        Open

        ({
        Severity: Minor
        Found in build.js by eslint

        Disallow Unused Expressions (no-unused-expressions)

        An unused expression which has no effect on the state of the program indicates a logic error.

        For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

        Rule Details

        This rule aims to eliminate unused expressions which have no effect on the state of the program.

        This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

        var i = 0;
        function increment() { i += 1; }
        increment(); // return value is unused, but i changed as a side effect
        
        var nThings = 0;
        function Thing() { nThings += 1; }
        new Thing(); // constructed object is unused, but nThings changed as a side effect

        This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

        Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

        Options

        This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

        • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
        • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
        • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

        These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

        Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

        /*eslint no-unused-expressions: "error"*/
        
        0
        
        if(0) 0
        
        {0}
        
        f(0), {}
        
        a && b()
        
        a, b()
        
        c = a, b;
        
        a() && function namedFunctionInExpressionContext () {f();}
        
        (function anIncompleteIIFE () {});
        
        injectGlobal`body{ color: red; }`

        Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

        "use strict";
        "use asm"
        "use stricter";
        "use babel"
        "any other strings like this in the prologue";

        Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

        /*eslint no-unused-expressions: "error"*/
        
        {} // In this context, this is a block statement, not an object literal
        
        {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
        
        function namedFunctionDeclaration () {}
        
        (function aGenuineIIFE () {}());
        
        f()
        
        a = 0
        
        new C
        
        delete a.b
        
        void a

        allowShortCircuit

        Examples of incorrect code for the { "allowShortCircuit": true } option:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
        
        a || b

        Examples of correct code for the { "allowShortCircuit": true } option:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
        
        a && b()
        a() || (b = c)

        allowTernary

        Examples of incorrect code for the { "allowTernary": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
        
        a ? b : 0
        a ? b : c()

        Examples of correct code for the { "allowTernary": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
        
        a ? b() : c()
        a ? (b = c) : d()

        allowShortCircuit and allowTernary

        Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
        
        a ? b() || (c = d) : e()

        allowTaggedTemplates

        Examples of incorrect code for the { "allowTaggedTemplates": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
        
        `some untagged template string`;

        Examples of correct code for the { "allowTaggedTemplates": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
        
        tag`some tagged template string`;

        Source: http://eslint.org/docs/rules/

        Expected '===' and instead saw '=='.
        Open

                    if ((this.page.name == name) && (this.page.data == data)) {
        Severity: Minor
        Found in framework/page.js by eslint

        Require === and !== (eqeqeq)

        It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

        The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

        • [] == false
        • [] == ![]
        • 3 == "03"

        If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

        Rule Details

        This rule is aimed at eliminating the type-unsafe equality operators.

        Examples of incorrect code for this rule:

        /*eslint eqeqeq: "error"*/
        
        if (x == 42) { }
        
        if ("" == text) { }
        
        if (obj.getStuff() != undefined) { }

        The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

        Options

        always

        The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

        Examples of incorrect code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a == b
        foo == true
        bananas != 1
        value == undefined
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        Examples of correct code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a === b
        foo === true
        bananas !== 1
        value === undefined
        typeof foo === 'undefined'
        'hello' !== 'world'
        0 === 0
        true === true
        foo === null

        This rule optionally takes a second argument, which should be an object with the following supported properties:

        • "null": Customize how this rule treats null literals. Possible values:
          • always (default) - Always use === or !==.
          • never - Never use === or !== with null.
          • ignore - Do not apply this rule to null.

        smart

        The "smart" option enforces the use of === and !== except for these cases:

        • Comparing two literal values
        • Evaluating the value of typeof
        • Comparing against null

        Examples of incorrect code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        // comparing two variables requires ===
        a == b
        
        // only one side is a literal
        foo == true
        bananas != 1
        
        // comparing to undefined requires ===
        value == undefined

        Examples of correct code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        allow-null

        Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

        ["error", "always", {"null": "ignore"}]

        When Not To Use It

        If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

        Expected '===' and instead saw '=='.
        Open

                    ((location.protocol == 'https:') && (port == '443'))) {
        Severity: Minor
        Found in util/dom.js by eslint

        Require === and !== (eqeqeq)

        It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

        The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

        • [] == false
        • [] == ![]
        • 3 == "03"

        If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

        Rule Details

        This rule is aimed at eliminating the type-unsafe equality operators.

        Examples of incorrect code for this rule:

        /*eslint eqeqeq: "error"*/
        
        if (x == 42) { }
        
        if ("" == text) { }
        
        if (obj.getStuff() != undefined) { }

        The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

        Options

        always

        The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

        Examples of incorrect code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a == b
        foo == true
        bananas != 1
        value == undefined
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        Examples of correct code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a === b
        foo === true
        bananas !== 1
        value === undefined
        typeof foo === 'undefined'
        'hello' !== 'world'
        0 === 0
        true === true
        foo === null

        This rule optionally takes a second argument, which should be an object with the following supported properties:

        • "null": Customize how this rule treats null literals. Possible values:
          • always (default) - Always use === or !==.
          • never - Never use === or !== with null.
          • ignore - Do not apply this rule to null.

        smart

        The "smart" option enforces the use of === and !== except for these cases:

        • Comparing two literal values
        • Evaluating the value of typeof
        • Comparing against null

        Examples of incorrect code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        // comparing two variables requires ===
        a == b
        
        // only one side is a literal
        foo == true
        bananas != 1
        
        // comparing to undefined requires ===
        value == undefined

        Examples of correct code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        allow-null

        Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

        ["error", "always", {"null": "ignore"}]

        When Not To Use It

        If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

        The function binding is unnecessary.
        Open

                    }.bind(this));
        Severity: Minor
        Found in component/todo-list/todo-list.js by eslint

        Disallow unnecessary function binding (no-extra-bind)

        The bind() method is used to create functions with specific this values and, optionally, binds arguments to specific values. When used to specify the value of this, it's important that the function actually use this in its function body. For example:

        var boundGetName = (function getName() {
            return this.name;
        }).bind({ name: "ESLint" });
        
        console.log(boundGetName());      // "ESLint"

        This code is an example of a good use of bind() for setting the value of this.

        Sometimes during the course of code maintenance, the this value is removed from the function body. In that case, you can end up with a call to bind() that doesn't accomplish anything:

        // useless bind
        var boundGetName = (function getName() {
            return "ESLint";
        }).bind({ name: "ESLint" });
        
        console.log(boundGetName());      // "ESLint"

        In this code, the reference to this has been removed but bind() is still used. In this case, the bind() is unnecessary overhead (and a performance hit) and can be safely removed.

        Rule Details

        This rule is aimed at avoiding the unnecessary use of bind() and as such will warn whenever an immediately-invoked function expression (IIFE) is using bind() and doesn't have an appropriate this value. This rule won't flag usage of bind() that includes function argument binding.

        Note: Arrow functions can never have their this value set using bind(). This rule flags all uses of bind() with arrow functions as a problem

        Examples of incorrect code for this rule:

        /*eslint no-extra-bind: "error"*/
        /*eslint-env es6*/
        
        var x = function () {
            foo();
        }.bind(bar);
        
        var x = (() => {
            foo();
        }).bind(bar);
        
        var x = (() => {
            this.foo();
        }).bind(bar);
        
        var x = function () {
            (function () {
              this.foo();
            }());
        }.bind(bar);
        
        var x = function () {
            function foo() {
              this.bar();
            }
        }.bind(baz);

        Examples of correct code for this rule:

        /*eslint no-extra-bind: "error"*/
        
        var x = function () {
            this.foo();
        }.bind(bar);
        
        var x = function (a) {
            return a + 1;
        }.bind(foo, bar);

        When Not To Use It

        If you are not concerned about unnecessary calls to bind(), you can safely disable this rule.

        Further Reading

        Unexpected require().
        Open

                require([pageModulePath], function (page) {
        Severity: Minor
        Found in framework/router.js by eslint

        Enforce require() on the top-level module scope (global-require)

        In Node.js, module dependencies are included using the require() function, such as:

        var fs = require("fs");

        While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

        function foo() {
        
            if (condition) {
                var fs = require("fs");
            }
        }

        Since require() does a synchronous load, it can cause performance problems when used in other locations.

        Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

        Rule Details

        This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

        Examples of incorrect code for this rule:

        /*eslint global-require: "error"*/
        /*eslint-env es6*/
        
        // calling require() inside of a function is not allowed
        function readFile(filename, callback) {
            var fs = require('fs');
            fs.readFile(filename, callback)
        }
        
        // conditional requires like this are also not allowed
        if (DEBUG) { require('debug'); }
        
        // a require() in a switch statement is also flagged
        switch(x) { case '1': require('1'); break; }
        
        // you may not require() inside an arrow function body
        var getModule = (name) => require(name);
        
        // you may not require() inside of a function body as well
        function getModule(name) { return require(name); }
        
        // you may not require() inside of a try/catch block
        try {
            require(unsafeModule);
        } catch(e) {
            console.log(e);
        }

        Examples of correct code for this rule:

        /*eslint global-require: "error"*/
        
        // all these variations of require() are ok
        require('x');
        var y = require('y');
        var z;
        z = require('z').initialize();
        
        // requiring a module and using it in a function is ok
        var fs = require('fs');
        function readFile(filename, callback) {
            fs.readFile(filename, callback)
        }
        
        // you can use a ternary to determine which module to require
        var logger = DEBUG ? require('dev-logger') : require('logger');
        
        // if you want you can require() at the end of your module
        function doSomethingA() {}
        function doSomethingB() {}
        var x = require("x"),
            z = require("z");

        When Not To Use It

        If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

        Expected '===' and instead saw '=='.
        Open

                    if ((tagNameLower.indexOf('-') != -1) || (String(node) == '[object HTMLUnknownElement]') ||
        Severity: Minor
        Found in lib-ext/knockout-extended.js by eslint

        Require === and !== (eqeqeq)

        It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

        The reason for this is that == and != do type coercion which follows the rather obscure Abstract Equality Comparison Algorithm. For instance, the following statements are all considered true:

        • [] == false
        • [] == ![]
        • 3 == "03"

        If one of those occurs in an innocent-looking statement such as a == b the actual problem is very difficult to spot.

        Rule Details

        This rule is aimed at eliminating the type-unsafe equality operators.

        Examples of incorrect code for this rule:

        /*eslint eqeqeq: "error"*/
        
        if (x == 42) { }
        
        if ("" == text) { }
        
        if (obj.getStuff() != undefined) { }

        The --fix option on the command line automatically fixes some problems reported by this rule. A problem is only fixed if one of the operands is a typeof expression, or if both operands are literals with the same type.

        Options

        always

        The "always" option (default) enforces the use of === and !== in every situation (except when you opt-in to more specific handling of null [see below]).

        Examples of incorrect code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a == b
        foo == true
        bananas != 1
        value == undefined
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        Examples of correct code for the "always" option:

        /*eslint eqeqeq: ["error", "always"]*/
        
        a === b
        foo === true
        bananas !== 1
        value === undefined
        typeof foo === 'undefined'
        'hello' !== 'world'
        0 === 0
        true === true
        foo === null

        This rule optionally takes a second argument, which should be an object with the following supported properties:

        • "null": Customize how this rule treats null literals. Possible values:
          • always (default) - Always use === or !==.
          • never - Never use === or !== with null.
          • ignore - Do not apply this rule to null.

        smart

        The "smart" option enforces the use of === and !== except for these cases:

        • Comparing two literal values
        • Evaluating the value of typeof
        • Comparing against null

        Examples of incorrect code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        // comparing two variables requires ===
        a == b
        
        // only one side is a literal
        foo == true
        bananas != 1
        
        // comparing to undefined requires ===
        value == undefined

        Examples of correct code for the "smart" option:

        /*eslint eqeqeq: ["error", "smart"]*/
        
        typeof foo == 'undefined'
        'hello' != 'world'
        0 == 0
        true == true
        foo == null

        allow-null

        Deprecated: Instead of using this option use "always" and pass a "null" option property with value "ignore". This will tell eslint to always enforce strict equality except when comparing with the null literal.

        ["error", "always", {"null": "ignore"}]

        When Not To Use It

        If you don't want to enforce a style for using equality operators, then it's safe to disable this rule. Source: http://eslint.org/docs/rules/

        The function binding is unnecessary.
        Open

                            }.bind(this));
        Severity: Minor
        Found in component/todo-list/todo-list.js by eslint

        Disallow unnecessary function binding (no-extra-bind)

        The bind() method is used to create functions with specific this values and, optionally, binds arguments to specific values. When used to specify the value of this, it's important that the function actually use this in its function body. For example:

        var boundGetName = (function getName() {
            return this.name;
        }).bind({ name: "ESLint" });
        
        console.log(boundGetName());      // "ESLint"

        This code is an example of a good use of bind() for setting the value of this.

        Sometimes during the course of code maintenance, the this value is removed from the function body. In that case, you can end up with a call to bind() that doesn't accomplish anything:

        // useless bind
        var boundGetName = (function getName() {
            return "ESLint";
        }).bind({ name: "ESLint" });
        
        console.log(boundGetName());      // "ESLint"

        In this code, the reference to this has been removed but bind() is still used. In this case, the bind() is unnecessary overhead (and a performance hit) and can be safely removed.

        Rule Details

        This rule is aimed at avoiding the unnecessary use of bind() and as such will warn whenever an immediately-invoked function expression (IIFE) is using bind() and doesn't have an appropriate this value. This rule won't flag usage of bind() that includes function argument binding.

        Note: Arrow functions can never have their this value set using bind(). This rule flags all uses of bind() with arrow functions as a problem

        Examples of incorrect code for this rule:

        /*eslint no-extra-bind: "error"*/
        /*eslint-env es6*/
        
        var x = function () {
            foo();
        }.bind(bar);
        
        var x = (() => {
            foo();
        }).bind(bar);
        
        var x = (() => {
            this.foo();
        }).bind(bar);
        
        var x = function () {
            (function () {
              this.foo();
            }());
        }.bind(bar);
        
        var x = function () {
            function foo() {
              this.bar();
            }
        }.bind(baz);

        Examples of correct code for this rule:

        /*eslint no-extra-bind: "error"*/
        
        var x = function () {
            this.foo();
        }.bind(bar);
        
        var x = function (a) {
            return a + 1;
        }.bind(foo, bar);

        When Not To Use It

        If you are not concerned about unnecessary calls to bind(), you can safely disable this rule.

        Further Reading

        Element (section.main) is overqualified, just use .main without element name.
        Open

        .error section.main {
        Severity: Minor
        Found in app/error/error.css by csslint
        Severity
        Category
        Status
        Source
        Language