onlyurei/todomvc-knockout-spa

View on GitHub

Showing 3 of 24 total issues

Function init has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        init: function (name, data, path, controller) {
            this.loading = false;

            name = name.toLowerCase();

Severity: Minor
Found in framework/page.js - About 1 hr to fix

    Consider simplifying this complex logical expression.
    Open

            if (href && !href.startsWith('#') && ((origin === window.location.origin) || !origin) &&
                ($(this).attr('target') != '_blank') && !$(this).data('go') && !event.ctrlKey && !event.metaKey) {
                event.preventDefault();
                Page.loading = true;
                router.setRoute(href);
    Severity: Critical
    Found in framework/router.js - About 1 hr to fix

      Function constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              constructor: function (params) {
                  this.filter = params.filter;
                  this.storageKey = params.storageKey || 'todos';
                  try {
                      this.models =
      Severity: Minor
      Found in component/todo-list/todo-list.js - About 1 hr to fix
        Severity
        Category
        Status
        Source
        Language