Sign upLogin

ontohub/ontohub

View on GitHub
Star
app/helpers/navigation_helper.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method ontology_nav has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def ontology_nav(ontology, current_page)
    resource = resource_chain.last

    content_page = ontology.distributed? ? :children : :symbols
    @top_level_pages = [
Severity: Major
Found in app/helpers/navigation_helper.rb - About 2 hrs to fix

    Method ontology_nav has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def ontology_nav(ontology, current_page)
    resource = resource_chain.last

    content_page = ontology.distributed? ? :children : :symbols
    @top_level_pages = [
    Severity: Minor
    Found in app/helpers/navigation_helper.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method active_navigation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def active_navigation(controller)
    alternatives = [controller.to_s, controller.to_s.gsub('_', '/')]
    if params[:repository_id]
      if params[:ontology_id]
        'active' if controller == :ontologies
    Severity: Minor
    Found in app/helpers/navigation_helper.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method subnavigation has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def subnavigation(resource, pages, current_page, options = {},
    additional_actions = [], partial: '/shared/subnavigation')
    Severity: Minor
    Found in app/helpers/navigation_helper.rb - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status