Sign upLogin

ontohub/ontohub

View on GitHub
Star
lib/permissionable.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method permission? has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  def permission?(role, user)
    # Deny if user is nil
    return false unless user

    # Deny if user is of wrong type
Severity: Minor
Found in lib/permissionable.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return true if perm.role == 'owner' and role == :reader
Severity: Major
Found in lib/permissionable.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return true if perm.role == 'editor' and role == :reader
    Severity: Major
    Found in lib/permissionable.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return true if perm.role == 'owner' and role == :editor
      Severity: Major
      Found in lib/permissionable.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status