Sign upLogin

opal/opal

View on GitHub
Star
lib/opal/nodes/if.rb

Summary

Maintainability
C
1 day
Test Coverage

Method compile_with_if has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Wontfix

      def compile_with_if
        push_closure if expects_expression?

        truthy = self.truthy
        falsy = self.falsy
Severity: Minor
Found in lib/opal/nodes/if.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method could_become_switch_branch? has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def could_become_switch_branch?(body)
        if !body
          return true
        elsif body.type != :if
          if valid_switch_body?(body)
Severity: Minor
Found in lib/opal/nodes/if.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compile_with_if has 33 lines of code (exceeds 30 allowed). Consider refactoring.
Open

      def compile_with_if
        push_closure if expects_expression?

        truthy = self.truthy
        falsy = self.falsy
Severity: Minor
Found in lib/opal/nodes/if.rb - About 1 hr to fix

    Method could_become_switch? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def could_become_switch?
        return false if expects_expression?

        return true if sexp.meta[:switch_child]
    Severity: Minor
    Found in lib/opal/nodes/if.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method compile_switch_case has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def compile_switch_case(test)
        line "case ", expr(test), ":"
        if @switch_additional_rules
          @switch_additional_rules.each do |rule|
            line "case ", expr(rule), ":"
    Severity: Minor
    Found in lib/opal/nodes/if.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method handle_additional_switch_rules has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def handle_additional_switch_rules(additional_rules)
        switch_additional_rules = []
        while additional_rules
          match = SWITCH_BRANCH_TEST_MATCH.match(additional_rules) || SWITCH_BRANCH_TEST_MATCH_CONTINUED.match(additional_rules)
          return false unless match
    Severity: Minor
    Found in lib/opal/nodes/if.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method compile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Wontfix

          def compile
        if should_compile_as_simple_expression?
          if true_body == s(:true)
            compile_with_binary_or
          elsif false_body == s(:false)
    Severity: Minor
    Found in lib/opal/nodes/if.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

            return false unless switch_additional_rules # It's ok for them to be empty, but false denotes a mismatch
    Severity: Major
    Found in lib/opal/nodes/if.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false unless valid_switch_body?(true_body)
      Severity: Major
      Found in lib/opal/nodes/if.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return false unless could_become_switch_branch?(false_body)
        Severity: Major
        Found in lib/opal/nodes/if.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return false unless valid_switch_body?(true_body)
          Severity: Major
          Found in lib/opal/nodes/if.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return false unless switch_variable == @switch_variable
            Severity: Major
            Found in lib/opal/nodes/if.rb - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Wontfix

                    def compile_with_binary_and
        if sexp.meta[:do_js_truthy_on_true_body]
          truthy = js_truthy(true_body || s(:nil))
        else
          truthy = expr(true_body || s(:nil))
              Severity: Minor
              Found in lib/opal/nodes/if.rb and 1 other location - About 25 mins to fix
              lib/opal/nodes/if.rb on lines 143..153

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Wontfix

                    def compile_with_binary_or
        if sexp.meta[:do_js_truthy_on_false_body]
          falsy = js_truthy(false_body || s(:nil))
        else
          falsy = expr(false_body || s(:nil))
              Severity: Minor
              Found in lib/opal/nodes/if.rb and 1 other location - About 25 mins to fix
              lib/opal/nodes/if.rb on lines 130..140

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status