Sign upLogin

opal/opal

View on GitHub
Star
opal/corelib/enumerable.rb

Summary

Maintainability
F
3 days
Test Coverage

Method one? has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def one?(pattern = undefined, &block)
    count = 0

    if `pattern !== undefined`
      each do |*value|
Severity: Minor
Found in opal/corelib/enumerable.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cycle has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def cycle(n = nil, &block)
    unless block_given?
      return enum_for(:cycle, n) do
        if n.nil?
          respond_to?(:size) ? ::Float::INFINITY : nil
Severity: Minor
Found in opal/corelib/enumerable.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method all? has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def all?(pattern = undefined, &block)
    if `pattern !== undefined`
      each do |*value|
        comparable = `comparableForPattern(value)`
Severity: Minor
Found in opal/corelib/enumerable.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method slice_before has 46 lines of code (exceeds 30 allowed). Consider refactoring.
Open

  def slice_before(pattern = undefined, &block)
    if `pattern === undefined && block === nil`
      ::Kernel.raise ::ArgumentError, 'both pattern and block are given'
    end
Severity: Minor
Found in opal/corelib/enumerable.rb - About 1 hr to fix

    Method cycle has 41 lines of code (exceeds 30 allowed). Consider refactoring.
    Open

      def cycle(n = nil, &block)
    unless block_given?
      return enum_for(:cycle, n) do
        if n.nil?
          respond_to?(:size) ? ::Float::INFINITY : nil
    Severity: Minor
    Found in opal/corelib/enumerable.rb - About 1 hr to fix

      Method any? has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def any?(pattern = undefined, &block)
    if `pattern !== undefined`
      each do |*value|
        comparable = `comparableForPattern(value)`
      Severity: Minor
      Found in opal/corelib/enumerable.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method none? has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def none?(pattern = undefined, &block)
    if `pattern !== undefined`
      each do |*value|
        comparable = `comparableForPattern(value)`
      Severity: Minor
      Found in opal/corelib/enumerable.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method min has 39 lines of code (exceeds 30 allowed). Consider refactoring.
      Open

        def min(n = nil, &block)
    unless n.nil?
      if block_given?
        return sort { |a, b| yield a, b }.take n
      else
      Severity: Minor
      Found in opal/corelib/enumerable.rb - About 1 hr to fix

        Method each_cons has 34 lines of code (exceeds 30 allowed). Consider refactoring.
        Open

          def each_cons(n, &block)
    if `arguments.length != 1`
      ::Kernel.raise ::ArgumentError, "wrong number of arguments (#{`arguments.length`} for 1)"
    end
        Severity: Minor
        Found in opal/corelib/enumerable.rb - About 1 hr to fix

          Method grep has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def grep(pattern, &block)
    result = []

    each do |*value|
      cmp = `comparableForPattern(value)`
          Severity: Minor
          Found in opal/corelib/enumerable.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method each_cons has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

            def each_cons(n, &block)
    if `arguments.length != 1`
      ::Kernel.raise ::ArgumentError, "wrong number of arguments (#{`arguments.length`} for 1)"
    end
          Severity: Minor
          Found in opal/corelib/enumerable.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method inject has 32 lines of code (exceeds 30 allowed). Consider refactoring.
          Open

            def inject(object = undefined, sym = undefined, &block)
    %x{
      var result = object;

      if (block !== nil && sym === undefined) {
          Severity: Minor
          Found in opal/corelib/enumerable.rb - About 1 hr to fix

            Method first has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def first(number = undefined)
    if `number === undefined`
      each do |value|
        return value
      end
            Severity: Minor
            Found in opal/corelib/enumerable.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method find_index has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def find_index(object = undefined, &block)
    return enum_for :find_index if `object === undefined && block === nil`

    %x{
      if (object != null && block !== nil) {
            Severity: Minor
            Found in opal/corelib/enumerable.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method grep_v has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              def grep_v(pattern, &block)
    result = []

    each do |*value|
      cmp = `comparableForPattern(value)`
            Severity: Minor
            Found in opal/corelib/enumerable.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method each_slice has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              def each_slice(n, &block)
    n = `$coerce_to(#{n}, #{::Integer}, 'to_int')`

    if `n <= 0`
      ::Kernel.raise ::ArgumentError, 'invalid slice size'
            Severity: Minor
            Found in opal/corelib/enumerable.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method sum has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Wontfix

              def sum(initial = 0)
    result = initial
    compensation = 0

    each do |*args|
            Severity: Minor
            Found in opal/corelib/enumerable.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method uniq has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def uniq(&block)
    hash = {}

    each do |*args|
      value = ::Opal.destructure(args)
            Severity: Minor
            Found in opal/corelib/enumerable.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def grep(pattern, &block)
    result = []

    each do |*value|
      cmp = `comparableForPattern(value)`
            Severity: Minor
            Found in opal/corelib/enumerable.rb and 1 other location - About 55 mins to fix
            opal/corelib/enumerable.rb on lines 549..565

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              def grep_v(pattern, &block)
    result = []

    each do |*value|
      cmp = `comparableForPattern(value)`
            Severity: Minor
            Found in opal/corelib/enumerable.rb and 1 other location - About 55 mins to fix
            opal/corelib/enumerable.rb on lines 530..546

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status