Sign upLogin

opcotech/elemo

View on GitHub
Star
internal/repository/redis/organization.go

Summary

Maintainability
B
5 hrs
Test Coverage

Similar blocks of code found in 11 locations. Consider refactoring.
Open

func (r *CachedOrganizationRepository) Get(ctx context.Context, id model.ID) (*model.Organization, error) {
    var organization *model.Organization
    var err error

    key := composeCacheKey(model.ResourceTypeOrganization.String(), id.String())
Severity: Major
Found in internal/repository/redis/organization.go and 10 other locations - About 2 hrs to fix
internal/repository/redis/assignment.go on lines 74..96
internal/repository/redis/attachment.go on lines 60..82
internal/repository/redis/comment.go on lines 66..88
internal/repository/redis/document.go on lines 73..95
internal/repository/redis/issue.go on lines 81..103
internal/repository/redis/label.go on lines 55..77
internal/repository/redis/namespace.go on lines 54..76
internal/repository/redis/project.go on lines 58..80
internal/repository/redis/todo.go on lines 26..48
internal/repository/redis/user.go on lines 63..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 226.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

func (r *CachedOrganizationRepository) GetAll(ctx context.Context, offset, limit int) ([]*model.Organization, error) {
    var organizations []*model.Organization
    var err error

    key := composeCacheKey(model.ResourceTypeOrganization.String(), "GetAll", offset, limit)
Severity: Major
Found in internal/repository/redis/organization.go and 2 other locations - About 2 hrs to fix
internal/repository/redis/label.go on lines 79..101
internal/repository/redis/user.go on lines 111..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 224.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (r *CachedOrganizationRepository) AddMember(ctx context.Context, orgID, memberID model.ID) error {
    if err := clearOrganizationsKey(ctx, r.cacheRepo, orgID); err != nil {
        return err
    }
Severity: Minor
Found in internal/repository/redis/organization.go and 1 other location - About 30 mins to fix
internal/repository/redis/organization.go on lines 118..128

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (r *CachedOrganizationRepository) RemoveMember(ctx context.Context, orgID, memberID model.ID) error {
    if err := clearOrganizationsKey(ctx, r.cacheRepo, orgID); err != nil {
        return err
    }
Severity: Minor
Found in internal/repository/redis/organization.go and 1 other location - About 30 mins to fix
internal/repository/redis/organization.go on lines 106..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 120.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status