Sign upLogin

open-eats/openeats-api

View on GitHub
Star
v1/recipe/serializers.py

Summary

Maintainability
A
1 hr
Test Coverage

Function to_representation has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def to_representation(self, value):
        use_url = getattr(self, 'use_url', api_settings.UPLOADED_FILES_USE_URL)
        try:
            if not value:
                return None
Severity: Minor
Found in v1/recipe/serializers.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return super(ImageField, self).to_representation(value)
Severity: Major
Found in v1/recipe/serializers.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return url
    Severity: Major
    Found in v1/recipe/serializers.py - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status