Sign upLogin

open-learning-exchange/planet

View on GitHub
Star
src/app/configuration/configuration.component.ts

Summary

Maintainability
D
1 day
Test Coverage

Function ngOnInit has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  ngOnInit() {
    if (this.route.snapshot.data.update) {
      this.initUpdate();
    }
    this.loginForm = this.formBuilder.group({
Severity: Major
Found in src/app/configuration/configuration.component.ts - About 2 hrs to fix

    File configuration.component.ts has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { Component, OnInit, ViewChild } from '@angular/core';
import { FormBuilder, FormGroup, Validators } from '@angular/forms';
import { CouchService } from '../shared/couchdb.service';
import { ValidatorService } from '../validators/validator.service';
import { PlanetMessageService } from '../shared/planet-message.service';
    Severity: Minor
    Found in src/app/configuration/configuration.component.ts - About 2 hrs to fix

      Function createConfigurationDocs has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        createConfigurationDocs() {
    const {
      confirmPassword,
      ...credentials
    } = this.loginForm.value;
      Severity: Minor
      Found in src/app/configuration/configuration.component.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              this.configurationService.updateConfiguration(configuration).pipe(finalize(spinnerOff)).subscribe(
        () => this.stateService.requestData('configurations', 'local'),
        err => {
          this.planetMessageService.showAlert($localize`There was an error updating the configuration`);
        }, () => {
        Severity: Major
        Found in src/app/configuration/configuration.component.ts and 1 other location - About 4 hrs to fix
        src/app/manager-dashboard/manager-aiservices.component.ts on lines 91..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 129.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

          constructor(
    private formBuilder: FormBuilder,
    private couchService: CouchService,
    private planetMessageService: PlanetMessageService,
    private validatorService: ValidatorService,
        Severity: Major
        Found in src/app/configuration/configuration.component.ts and 5 other locations - About 2 hrs to fix
        src/app/manager-dashboard/requests/requests.component.ts on lines 38..47
        src/app/manager-dashboard/sync.directive.ts on lines 22..31
        src/app/news/news-list-item.component.ts on lines 38..47
        src/app/shared/dialogs/change-password.directive.ts on lines 91..100
        src/app/submissions/submissions.service.ts on lines 37..46

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 80.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status