open-learning-exchange/planet

View on GitHub
src/app/manager-dashboard/reports/reports-detail.component.ts

Summary

Maintainability
A
2 hrs
Test Coverage

File reports-detail.component.ts has 431 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

import { Component, OnInit, OnDestroy, ViewEncapsulation, HostBinding, ViewChild } from '@angular/core';
import { ActivatedRoute, ParamMap, Router } from '@angular/router';
import { FormGroup, FormBuilder } from '@angular/forms';
import { combineLatest, Subject, of } from 'rxjs';
import { takeUntil, take } from 'rxjs/operators';
Severity: Minor
Found in src/app/manager-dashboard/reports/reports-detail.component.ts - About 6 hrs to fix

    ReportsDetailComponent has 32 functions (exceeds 20 allowed). Consider refactoring.
    Wontfix

    @Component({
      templateUrl: './reports-detail.component.html',
      styleUrls: [ 'reports-detail.scss' ],
      encapsulation: ViewEncapsulation.None
    })
    Severity: Minor
    Found in src/app/manager-dashboard/reports/reports-detail.component.ts - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Invalid

        constructor(
          private activityService: ReportsService,
          private stateService: StateService,
          private route: ActivatedRoute,
          private router: Router,
      src/app/users/users-achievements/users-achievements-update.component.ts on lines 42..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 100.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        openMemberView(user) {
          this.dialog.open(UserProfileDialogComponent, {
            data: { member: { name: user.name, userPlanetCode: user.planetCode } },
            autoFocus: false
          });
      src/app/tasks/tasks.component.ts on lines 174..177

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        openCourseView(courseId) {
          this.dialog.open(CoursesViewDetailDialogComponent, {
            data: { courseId: courseId },
            minWidth: '600px',
            maxWidth: '90vw',
      src/app/courses/courses.component.ts on lines 460..468
      src/app/teams/teams-view.component.ts on lines 521..529

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 57.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status