open-learning-exchange/planet

View on GitHub
src/app/teams/teams-view.component.ts

Summary

Maintainability
D
2 days
Test Coverage

File teams-view.component.ts has 510 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Component, OnInit, OnDestroy, ViewChild, AfterViewChecked, ViewEncapsulation, HostListener } from '@angular/core';
import { CouchService } from '../shared/couchdb.service';
import { Router, ActivatedRoute, ParamMap } from '@angular/router';
import { MatDialog, MatDialogRef } from '@angular/material/dialog';
import { MatTab } from '@angular/material/tabs';
Severity: Major
Found in src/app/teams/teams-view.component.ts - About 1 day to fix

    TeamsViewComponent has 39 functions (exceeds 20 allowed). Consider refactoring.
    Open

    @Component({
      templateUrl: './teams-view.component.html',
      styleUrls: [ './teams-view.scss' ],
      encapsulation: ViewEncapsulation.None
    })
    Severity: Minor
    Found in src/app/teams/teams-view.component.ts - About 5 hrs to fix

      Function initTeam has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

        initTeam(teamId: string) {
          this.newsService.newsUpdated$.pipe(takeUntil(this.onDestroy$))
            .subscribe(news => this.news = news.map(post => ({
              ...post, public: ((post.doc.viewIn || []).find(view => view._id === teamId) || {}).public
            })));
      Severity: Minor
      Found in src/app/teams/teams-view.component.ts - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Invalid

          constructor(
            private couchService: CouchService,
            private userService: UserService,
            private router: Router,
            private route: ActivatedRoute,
        Severity: Major
        Found in src/app/teams/teams-view.component.ts and 2 other locations - About 4 hrs to fix
        src/app/courses/courses.component.ts on lines 112..135
        src/app/login/login-form.component.ts on lines 52..76

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 127.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            ).subscribe(() => {
              this.dialogRef.close();
              this.planetMessageService.showMessage($localize`Member${(selected.length > 1 ? 's' : '')} added successfully`);
            });
        Severity: Major
        Found in src/app/teams/teams-view.component.ts and 1 other location - About 1 hr to fix
        src/app/meetups/view-meetups/meetups-view.component.ts on lines 130..133

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 60.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          openCourseView(courseId) {
            this.dialog.open(CoursesViewDetailDialogComponent, {
              data: { courseId: courseId },
              minWidth: '600px',
              maxWidth: '90vw',
        Severity: Major
        Found in src/app/teams/teams-view.component.ts and 2 other locations - About 1 hr to fix
        src/app/courses/courses.component.ts on lines 461..469
        src/app/manager-dashboard/reports/reports-detail.component.ts on lines 470..478

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          openMemberDialog(member) {
            this.dialog.open(UserProfileDialogComponent, {
              data: { member },
              maxWidth: '90vw',
              maxHeight: '90vh'
        Severity: Minor
        Found in src/app/teams/teams-view.component.ts and 1 other location - About 35 mins to fix
        src/app/teams/teams-member.component.ts on lines 53..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status