Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
ApiBundle/Transformer/BlockComponentCollectionTransformer.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$params'.
Open

    public function transform($blockComponentCollection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/BlockComponentCollectionTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractTransformer
Open

class BlockComponentCollectionTransformer extends AbstractTransformer
Severity: Critical
Found in ApiBundle/Transformer/BlockComponentCollectionTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\BlockComponentCollectionTransformer::getContext
Open

            $facade->addBlockComponents($this->getContext()->transform('block_component', $blockComponent));
Severity: Critical
Found in ApiBundle/Transformer/BlockComponentCollectionTransformer.php by phan

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($blockComponentCollection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/BlockComponentCollectionTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\BlockComponentCollectionTransformer::newFacade
Open

        $facade = $this->newFacade();
Severity: Critical
Found in ApiBundle/Transformer/BlockComponentCollectionTransformer.php by phan

Avoid excessively long variable names like $blockComponentCollection. Keep variable name length under 20.
Open

    public function transform($blockComponentCollection, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/BlockComponentCollectionTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category
Status