open-orchestra/open-orchestra-cms-bundle

View on GitHub
ApiBundle/Transformer/KeywordTransformer.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$params'.
Open

    public function transform($keyword, array $params = array())

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Avoid unused parameters such as '$params'.
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method __construct from undeclared class \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

            throw new TransformerParameterTypeException();

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\KeywordTransformer::newFacade
Open

        $facade = $this->newFacade();

Reference to undeclared property \OpenOrchestra\ApiBundle\Transformer\KeywordTransformer->authorizationChecker
Open

        $facade->addRight('can_edit', $this->authorizationChecker->isGranted(ContributionActionInterface::EDIT, $keyword));

Call to method getLabel from undeclared class \OpenOrchestra\ModelInterface\Model\KeywordInterface
Open

        $facade->label = $keyword->getLabel();

Reference to undeclared property \OpenOrchestra\ApiBundle\Transformer\KeywordTransformer->authorizationChecker
Open

        $facade->addRight('can_delete', $this->authorizationChecker->isGranted(ContributionActionInterface::DELETE, $keyword) &&

Reference to undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractSecurityCheckerAwareTransformer
Open

        parent::__construct($facadeClass, $authorizationChecker);

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractSecurityCheckerAwareTransformer
Open

class KeywordTransformer extends AbstractSecurityCheckerAwareTransformer

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($keyword, array $params = array())

@throws type of transform has undeclared type \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

    public function transform($keyword, array $params = array())

Return type of reverseTransform() is undeclared type \OpenOrchestra\ModelInterface\Model\KeywordInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())

Reference to instance property id from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

        if (null !== $facade->id) {

Parameter $authorizationChecker has undeclared type \Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface
Open

    public function __construct(

Parameter $keywordRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\KeywordRepositoryInterface
Open

    public function __construct(

Parameter $facade has undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function reverseTransform(FacadeInterface $facade, array $params = array())

Call to method find from undeclared class \OpenOrchestra\ModelInterface\Repository\KeywordRepositoryInterface
Open

            return $this->keywordRepository->find($facade->id);

Call to method getLabel from undeclared class \OpenOrchestra\ModelInterface\Model\KeywordInterface
Open

        $facade->label = $keyword->getLabel();

Reference to instance property id from undeclared class \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

            return $this->keywordRepository->find($facade->id);

Parameter $keyword has undeclared type \OpenOrchestra\ModelInterface\Model\KeywordInterface
Open

    public function transform($keyword, array $params = array())

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\KeywordInterface
Open

        if (!$keyword instanceof KeywordInterface) {

Call to method getId from undeclared class \OpenOrchestra\ModelInterface\Model\KeywordInterface
Open

        $facade->id = $keyword->getId();

Call to method countUse from undeclared class \OpenOrchestra\ModelInterface\Model\KeywordInterface
Open

        $facade->numberUse = $keyword->countUse();

Line exceeds 120 characters; contains 128 characters
Open

        $facade->addRight('can_delete', $this->authorizationChecker->isGranted(ContributionActionInterface::DELETE, $keyword) &&

Line exceeds 120 characters; contains 123 characters
Open

        $facade->addRight('can_edit', $this->authorizationChecker->isGranted(ContributionActionInterface::EDIT, $keyword));

There are no issues that match your filters.

Category
Status