open-orchestra/open-orchestra-cms-bundle

View on GitHub
ApiBundle/Transformer/SiteCollectionTransformer.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid unused parameters such as '$params'.
Open

    public function transform($siteCollection, array $params = array())

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractTransformer
Open

class SiteCollectionTransformer extends AbstractTransformer

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\SiteCollectionTransformer::newFacade
Open

        $facade = $this->newFacade();

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($siteCollection, array $params = array())

Parameter $siteCollection has undeclared type \Doctrine\Common\Collections\Collection
Open

    public function transform($siteCollection, array $params = array())

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\SiteCollectionTransformer::getContext
Open

            $facade->addSite($this->getContext()->transform('site', $site));

There are no issues that match your filters.

Category
Status