Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
ApiBundle/Transformer/SiteTransformer.php

Summary

Maintainability
A
25 mins
Test Coverage

Function transform has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public function transform($site, array $params = array())
    {
        if (!$site instanceof SiteInterface) {
            throw new TransformerParameterTypeException();
        }
Severity: Minor
Found in ApiBundle/Transformer/SiteTransformer.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid unused parameters such as '$params'.
Open

    public function transform($site, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/SiteTransformer.php by phpmd

UnusedFormalParameter

Since: 0.2

Avoid passing parameters to methods or constructors and then not using those parameters.

Example

class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

Call to method __construct from undeclared class \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

            throw new TransformerParameterTypeException();
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to method getSiteId from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

        $facade->siteId = $site->getSiteId();
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

@throws type of transform has undeclared type \OpenOrchestra\BaseApi\Exceptions\TransformerParameterTypeException
Open

    public function transform($site, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to method getLanguages from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

        foreach ($site->getLanguages() as $language) {
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to method getId from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

        $facade->id = $site->getId();
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\SiteTransformer::hasGroup
Open

        if ($this->hasGroup(CMSGroupContext::SITE_MAIN_ALIAS)) {
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to method getMainAlias from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

            $facade->mainAlias = $this->getContext()->transform('site_alias', $site->getMainAlias());
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\SiteTransformer::hasGroup
Open

        if ($this->hasGroup(CMSGroupContext::BLOCKS)) {
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Return type of transform() is undeclared type \OpenOrchestra\BaseApi\Facade\FacadeInterface
Open

    public function transform($site, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\SiteTransformer::newFacade
Open

        $facade = $this->newFacade();
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\SiteTransformer::getContext
Open

            $facade->mainAlias = $this->getContext()->transform('site_alias', $site->getMainAlias());
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to method getBlocks from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

            foreach ($site->getBlocks() as $value) {
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Class extends undeclared class \OpenOrchestra\BaseApi\Transformer\AbstractTransformer
Open

class SiteTransformer extends AbstractTransformer
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

        if (!$site instanceof SiteInterface) {
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to undeclared method \OpenOrchestra\ApiBundle\Transformer\SiteTransformer::hasGroup
Open

        return $this->hasGroup(CMSGroupContext::SITE);
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Parameter $site has undeclared type \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

    public function transform($site, array $params = array())
Severity: Minor
Found in ApiBundle/Transformer/SiteTransformer.php by phan

Call to method getName from undeclared class \OpenOrchestra\ModelInterface\Model\SiteInterface
Open

        $facade->name = $site->getName();
Severity: Critical
Found in ApiBundle/Transformer/SiteTransformer.php by phan

There are no issues that match your filters.

Category
Status