Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/EventSubscriber/BlockFormTypeSubscriber.php

Summary

Maintainability
A
1 hr
Test Coverage

Function submit has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function submit(FormEvent $event)
    {
        $block = $event->getForm()->getData();
        if (null !== $block) {
            $blockAttributes = array();
Severity: Minor
Found in Backoffice/EventSubscriber/BlockFormTypeSubscriber.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid using static access to class '\Doctrine\Common\Util\Inflector' in method 'submit'.
Open

                    $setter = 'set' . Inflector::classify($key);
Severity: Minor
Found in Backoffice/EventSubscriber/BlockFormTypeSubscriber.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Call to method classify from undeclared class \Doctrine\Common\Util\Inflector
Open

                    $setter = 'set' . Inflector::classify($key);
Severity: Critical
Found in Backoffice/EventSubscriber/BlockFormTypeSubscriber.php by phan

Parameter $event has undeclared type \Symfony\Component\Form\FormEvent
Open

    public function submit(FormEvent $event)
Severity: Minor
Found in Backoffice/EventSubscriber/BlockFormTypeSubscriber.php by phan

Reference to constant SUBMIT from undeclared class \Symfony\Component\Form\FormEvents
Open

            FormEvents::SUBMIT => 'submit'
Severity: Critical
Found in Backoffice/EventSubscriber/BlockFormTypeSubscriber.php by phan

Call to method getForm from undeclared class \Symfony\Component\Form\FormEvent
Open

        $block = $event->getForm()->getData();
Severity: Critical
Found in Backoffice/EventSubscriber/BlockFormTypeSubscriber.php by phan

Call to method getForm from undeclared class \Symfony\Component\Form\FormEvent
Open

            foreach ($event->getForm()->all() as $key => $children) {
Severity: Critical
Found in Backoffice/EventSubscriber/BlockFormTypeSubscriber.php by phan

Class implements undeclared interface \Symfony\Component\EventDispatcher\EventSubscriberInterface
Open

class BlockFormTypeSubscriber implements EventSubscriberInterface
Severity: Critical
Found in Backoffice/EventSubscriber/BlockFormTypeSubscriber.php by phan

There are no issues that match your filters.

Category
Status