Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php

Summary

Maintainability
A
1 hr
Test Coverage

Method preSetData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function preSetData(FormEvent $event)
    {
        $form = $event->getForm();
        $data = $event->getData();
        if (null === $data->getId()) {
Severity: Minor
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php - About 1 hr to fix

The method preSetData uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $form->add('template', 'choice', array(
                'choices' => $this->getTemplateChoices(),
                'required' => true,
                'label' => 'open_orchestra_backoffice.form.node.template',
Severity: Minor
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Class implements undeclared interface \Symfony\Component\EventDispatcher\EventSubscriberInterface
Open

class NodeTemplateSelectionSubscriber implements EventSubscriberInterface
Severity: Critical
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Call to method getData from undeclared class \Symfony\Component\Form\FormEvent
Open

        $data = $event->getData();
Severity: Critical
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Reference to constant PRE_SET_DATA from undeclared class \Symfony\Component\Form\FormEvents
Open

            FormEvents::PRE_SET_DATA => 'preSetData'
Severity: Critical
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Call to method getForm from undeclared class \Symfony\Component\Form\FormEvent
Open

        $form = $event->getForm();
Severity: Critical
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Call to method getData from undeclared class \Symfony\Component\Form\FormEvent
Open

        $data = $event->getData();
Severity: Critical
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Parameter $event has undeclared type \Symfony\Component\Form\FormEvent
Open

    public function preSubmit(FormEvent $event)
Severity: Minor
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Call to method setData from undeclared class \Symfony\Component\Form\FormEvent
Open

            $event->setData($data);
Severity: Critical
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Parameter $siteRepository has undeclared type \OpenOrchestra\ModelInterface\Repository\SiteRepositoryInterface
Open

    public function __construct(
Severity: Minor
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Reference to constant PRE_SUBMIT from undeclared class \Symfony\Component\Form\FormEvents
Open

            FormEvents::PRE_SUBMIT => 'preSubmit',
Severity: Critical
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Call to method findOneBySiteId from undeclared class \OpenOrchestra\ModelInterface\Repository\SiteRepositoryInterface
Open

        $site = $this->siteRepository->findOneBySiteId($siteId);
Severity: Critical
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Call to method getForm from undeclared class \Symfony\Component\Form\FormEvent
Open

        $form = $event->getForm();
Severity: Critical
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Parameter $event has undeclared type \Symfony\Component\Form\FormEvent
Open

    public function preSetData(FormEvent $event)
Severity: Minor
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phan

Avoid excessively long variable names like $templateSetParameters. Keep variable name length under 20.
Open

        $templateSetParameters = $this->templateManager->getTemplateSetParameters();
Severity: Minor
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Expected 0 spaces after opening bracket; newline found
Open

        if (
Severity: Minor
Found in Backoffice/EventSubscriber/NodeTemplateSelectionSubscriber.php by phpcodesniffer

There are no issues that match your filters.

Category
Status