open-orchestra/open-orchestra-cms-bundle

View on GitHub
Backoffice/EventSubscriber/UpdateHistoryListSubscriber.php

Summary

Maintainability
A
0 mins
Test Coverage

The class UpdateHistoryListSubscriber has 16 public methods. Consider refactoring UpdateHistoryListSubscriber to keep number of public methods under 10.
Open

class UpdateHistoryListSubscriber implements EventSubscriberInterface
{
    protected $tokenManager;
    protected $objectManager;
    protected $historyClass;

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Missing class import via use statement (line '193', column '36').
Open

        $history->setUpdatedAt(new \DateTime());

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Reference to constant CONTENT_CREATION from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

            ContentEvents::CONTENT_CREATION => 'addContentCreationHistory',

Reference to constant NODE_DUPLICATE from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::NODE_DUPLICATE);

Reference to constant NODE_RESTORE from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::NODE_RESTORE => 'addNodeRestoreHistory',

Reference to constant NODE_CHANGE_STATUS from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::NODE_CHANGE_STATUS => 'addNodeChangeStatusHistory',

Reference to constant NODE_UPDATE from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::NODE_UPDATE => 'addNodeUpdateHistory',

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\ContentEvent
Open

    public function addContentUpdateHistory(ContentEvent $event)

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\ContentEvent
Open

    public function addContentRestoreHistory(ContentEvent $event)

Reference to constant NODE_RESTORE from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::NODE_RESTORE);

Reference to constant NODE_UPDATE_BLOCK from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::NODE_UPDATE_BLOCK => 'addNodeUpdateBlockHistory',

Reference to constant NODE_UPDATE_BLOCK_POSITION from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::NODE_UPDATE_BLOCK_POSITION => 'addNodeUpdateBlockPositionHistory',

Reference to constant CONTENT_DUPLICATE from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

        $this->addContentHistory($event, ContentEvents::CONTENT_DUPLICATE);

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\ContentEvent
Open

    public function addContentChangeStatusHistory(ContentEvent $event)

Reference to constant CONTENT_CHANGE_STATUS from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

        $this->addContentHistory($event, ContentEvents::CONTENT_CHANGE_STATUS);

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addPathUpdatedHistory(NodeEvent $event)

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addNodeDeleteBlockHistory(NodeEvent $event)

Reference to constant NODE_UPDATE_BLOCK_POSITION from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::NODE_UPDATE_BLOCK_POSITION);

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addNodeDuplicateHistory(NodeEvent $event)

Reference to constant NODE_DELETE_BLOCK from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::NODE_DELETE_BLOCK);

Call to method getContent from undeclared class \OpenOrchestra\ModelInterface\Event\ContentEvent
Open

        $document = $event->getContent();

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\HistorisableInterface
Open

        if ($document instanceof HistorisableInterface && !is_null($token)) {

Reference to constant NODE_DUPLICATE from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::NODE_DUPLICATE => 'addNodeDuplicateHistory',

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addNodeUpdateHistory(NodeEvent $event)

Call to method addHistory from undeclared class \OpenOrchestra\ModelInterface\Model\HistorisableInterface
Open

        $document->addHistory($history);

Parameter $objectManager has undeclared type \Doctrine\Common\Persistence\ObjectManager
Open

    public function __construct(TokenStorageInterface $tokenManager, ObjectManager $objectManager, $historyClass)

Parameter $tokenManager has undeclared type \Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface
Open

    public function __construct(TokenStorageInterface $tokenManager, ObjectManager $objectManager, $historyClass)

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\ContentEvent
Open

    public function addContentCreationHistory(ContentEvent $event)

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addNodeRestoreHistory(NodeEvent $event)

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addNodeAddLanguageHistory(NodeEvent $event)

Call to method getNode from undeclared class \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

        $document = $event->getNode();

Call to method flush from undeclared class \Doctrine\Common\Persistence\ObjectManager
Open

        $this->objectManager->flush();

Reference to constant CONTENT_DUPLICATE from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

            ContentEvents::CONTENT_DUPLICATE => 'addContentDuplicateHistory',

Class implements undeclared interface \Symfony\Component\EventDispatcher\EventSubscriberInterface
Open

class UpdateHistoryListSubscriber implements EventSubscriberInterface

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addNodeUpdateBlockHistory(NodeEvent $event)

Reference to constant NODE_UPDATE_BLOCK from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::NODE_UPDATE_BLOCK);

Call to method getToken from undeclared class \Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface
Open

        $token = $this->tokenManager->getToken();

Reference to constant CONTENT_CHANGE_STATUS from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

            ContentEvents::CONTENT_CHANGE_STATUS => 'addContentChangeStatusHistory',

Reference to constant CONTENT_RESTORE from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

        $this->addContentHistory($event, ContentEvents::CONTENT_RESTORE);

Reference to constant NODE_CREATION from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::NODE_CREATION);

Reference to constant CONTENT_RESTORE from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

            ContentEvents::CONTENT_RESTORE => 'addContentRestoreHistory',

Reference to constant PATH_UPDATED from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::PATH_UPDATED);

Call to method getUser from undeclared class \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open

        $user = $token->getUser();

Reference to constant NODE_CREATION from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::NODE_CREATION => 'addNodeCreationHistory',

Call to method getToken from undeclared class \Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface
Open

        $token = $this->tokenManager->getToken();

Checking instanceof against undeclared class \OpenOrchestra\ModelInterface\Model\HistorisableInterface
Open

        if ($document instanceof HistorisableInterface && !is_null($token)) {

Reference to constant CONTENT_CREATION from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

        $this->addContentHistory($event, ContentEvents::CONTENT_CREATION);

Reference to constant NODE_UPDATE from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::NODE_UPDATE);

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addNodeCreationHistory(NodeEvent $event)

Reference to constant NODE_ADD_LANGUAGE from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::NODE_ADD_LANGUAGE);

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addNodeChangeStatusHistory(NodeEvent $event)

Reference to constant CONTENT_UPDATE from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

            ContentEvents::CONTENT_UPDATE => 'addContentUpdateHistory',

Reference to constant NODE_DELETE_BLOCK from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::NODE_DELETE_BLOCK => 'addNodeDeleteBlockHistory',

Reference to constant CONTENT_UPDATE from undeclared class \OpenOrchestra\ModelInterface\ContentEvents
Open

        $this->addContentHistory($event, ContentEvents::CONTENT_UPDATE);

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\ContentEvent
Open

    public function addContentDuplicateHistory(ContentEvent $event)

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    public function addNodeUpdateBlockPositionHistory(NodeEvent $event)

Parameter $document has undeclared type \OpenOrchestra\ModelInterface\Model\HistorisableInterface
Open

    protected function addDocumentHistory(HistorisableInterface $document, TokenInterface $token, $eventType)

Reference to constant NODE_CHANGE_STATUS from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

        $this->addNodeHistory($event, NodeEvents::NODE_CHANGE_STATUS);

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\ContentEvent
Open

    protected function addContentHistory(ContentEvent $event, $eventType)

Parameter $event has undeclared type \OpenOrchestra\ModelInterface\Event\NodeEvent
Open

    protected function addNodeHistory(NodeEvent $event, $eventType)

Parameter $token has undeclared type \Symfony\Component\Security\Core\Authentication\Token\TokenInterface
Open

    protected function addDocumentHistory(HistorisableInterface $document, TokenInterface $token, $eventType)

Reference to constant PATH_UPDATED from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::PATH_UPDATED => 'addPathUpdatedHistory',

Reference to constant NODE_ADD_LANGUAGE from undeclared class \OpenOrchestra\ModelInterface\NodeEvents
Open

            NodeEvents::NODE_ADD_LANGUAGE => 'addNodeAddLanguageHistory',

There are no issues that match your filters.

Category
Status