Sign upLogin

open-orchestra/open-orchestra-cms-bundle

View on GitHub
Star
Backoffice/Form/DataTransformer/ChoicesOptionToArrayTransformer.php

Summary

Maintainability
A
0 mins
Test Coverage

Returning type null but reverseTransform() is declared to return array
Open

            return null;
Severity: Minor
Found in Backoffice/Form/DataTransformer/ChoicesOptionToArrayTransformer.php by phan

Call to method transform from undeclared class \OpenOrchestra\ModelInterface\Helper\SuppressSpecialCharacterHelperInterface
Open

            $choice = $this->suppressSpecialCharacterHelper->transform($choice, array('_','.'));
Severity: Critical
Found in Backoffice/Form/DataTransformer/ChoicesOptionToArrayTransformer.php by phan

Class implements undeclared interface \Symfony\Component\Form\DataTransformerInterface
Open

class ChoicesOptionToArrayTransformer implements DataTransformerInterface
Severity: Critical
Found in Backoffice/Form/DataTransformer/ChoicesOptionToArrayTransformer.php by phan

Parameter $suppressSpecialCharacterHelper has undeclared type \OpenOrchestra\ModelInterface\Helper\SuppressSpecialCharacterHelperInterface
Open

    public function __construct(SuppressSpecialCharacterHelperInterface $suppressSpecialCharacterHelper)
Severity: Minor
Found in Backoffice/Form/DataTransformer/ChoicesOptionToArrayTransformer.php by phan

Avoid excessively long variable names like $suppressSpecialCharacterHelper. Keep variable name length under 20.
Open

    protected $suppressSpecialCharacterHelper;
Severity: Minor
Found in Backoffice/Form/DataTransformer/ChoicesOptionToArrayTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $suppressSpecialCharacterHelper. Keep variable name length under 20.
Open

    public function __construct(SuppressSpecialCharacterHelperInterface $suppressSpecialCharacterHelper)
Severity: Minor
Found in Backoffice/Form/DataTransformer/ChoicesOptionToArrayTransformer.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

There are no issues that match your filters.

Category
Status