Backoffice/Form/DataTransformer/CsvToReferenceKeywordTransformer.php
The method getKeywordAsArray uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$keywords = $keywords->toArray();
foreach ($keywords as &$keyword) {
$keyword = $keyword->getId();
}- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Return type of reverseTransform() is undeclared type \Doctrine\Common\Collections\ArrayCollection Open
Open
public function reverseTransform($keywords)- Create a ticketCreate a ticket
- Exclude checks
Call to method toArray on non-class type string Open
Open
$keywords = $keywords->toArray();- Create a ticketCreate a ticket
- Exclude checks
Opening brace should be on a new line Open
Open
protected function getKeywordAsArray($keywords) {- Create a ticketCreate a ticket
- Exclude checks
Opening brace should be on a new line Open
Open
protected function getKeywordAsCondition($keywords) {- Create a ticketCreate a ticket
- Exclude checks